[GitHub] jmarantz commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

[GitBox <gi...@apache.org>]

jmarantz commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404475184
 
 
   How are you integrating the closure-library? Are you compiling
   <https://developers.google.com/closure/compiler/> your JavaScript with the
   closure library? Usually goog.require doesn't run when you load the page;
   it is handled at the compilation step. There are various ad-hoc ways of
   getting around this so you can load your closure-library dependencies
   without a compilation step. I use them myself, but only for debugging
   JavaScript.
   
   It's possible that PageSpeed's use of closure-compiled libraries (e.g. for
   detecting above-the-fold images) is interfering with some ad-hoc mechanism
   you've picked up somewhere. Or maybe PageSpeed's renaming of JavaScript
   files is getting in the way of that ad-hoc mechanism.
   
   It should be easy to get to the bottom of this if you give more detail
   about how you are using the closure library.
   
   
   On Thu, Jul 12, 2018 at 11:07 AM NisariAIT <no...@github.com> wrote:
   
   > No @Lofesa <https://github.com/Lofesa>. I have not enabled defer
   > javascript.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AB2kPai6mekcC2s-6jiZO6DKc9cI2KVIks5uFwOmgaJpZM4VKue4>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services