You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Polber (via GitHub)" <gi...@apache.org> on 2024/04/03 01:12:24 UTC
[PR] [yaml] add --providers and --providers_file flags [beam]
Polber opened a new pull request, #30835:
URL: https://github.com/apache/beam/pull/30835
Allows a user to separate the pipeline spec from the providers spec.
This is particularly useful when creating a catalog of transforms that is defined in a shared file that can be passed as an argument for multiple pipelines that utilize the transforms without the need to redefine and version control the providers.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Posted by "Polber (via GitHub)" <gi...@apache.org>.
Polber commented on PR #30835:
URL: https://github.com/apache/beam/pull/30835#issuecomment-2033365253
R: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #30835:
URL: https://github.com/apache/beam/pull/30835#issuecomment-2035551764
Rather than passing these via a side channel, could we reference the eternal provider definitions file in the yaml itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30835:
URL: https://github.com/apache/beam/pull/30835#issuecomment-2033366061
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Posted by "Polber (via GitHub)" <gi...@apache.org>.
Polber commented on PR #30835:
URL: https://github.com/apache/beam/pull/30835#issuecomment-2035797734
@robertwb That is a good idea. I went ahead and pushed changes to support something like:
```
pipeline:
...
providers: !include providers.yaml
```
However, I tested out a similar syntax with jinja, and using a custom template loader, it is possible to do something like:
```
pipeline:
...
providers: {% include 'providers.yaml' %}
```
In both cases, the framework will accept paths from the local filesystem or from GCS
(using `apache_beam.io.filesystems.FileSystems`)
---
Since YAML templates will most likely use jinja, gauging current dev list interaction, I am going to table this for now with the intent to add this feature with the templatization work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Posted by "Polber (via GitHub)" <gi...@apache.org>.
Polber closed pull request #30835: [yaml] add --providers and --providers_file flags
URL: https://github.com/apache/beam/pull/30835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org