[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #815: [#414] feat(client): support specifying per-partition's max concurrency to write in client side

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #815:
URL: https://github.com/apache/incubator-uniffle/pull/815#discussion_r1166209488


##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -258,6 +258,16 @@ private void flushToFile(ShuffleDataFlushEvent event) {
     }
   }
 
+  private int getMaxConcurrencyPerPartitionWrite(ShuffleDataFlushEvent event) {
+    ShuffleTaskInfo taskInfo = shuffleServer.getShuffleTaskManager().getShuffleTaskInfo(event.getAppId());
+    // For some tests.
+    if (taskInfo == null) {
+      LOG.warn("Should not happen that shuffle task info of {} is null.", event.getAppId());
+      return shuffleServerConf.get(SERVER_MAX_CONCURRENCY_OF_ONE_PARTITION);
+    }
+    return taskInfo.getMaxConcurrencyPerPartitionToWrite();

Review Comment:
   SGTM. 
   
   Currently, the default concurrency is specified by the shuffle server. So, I perfer introducing extra config of `max concurrency` to solve this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org