You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason van Zyl (JIRA)" <ji...@codehaus.org> on 2007/02/19 19:12:52 UTC

[jira] Created: (MNG-2837) Remove all caching from the ProjectBuilder

Remove all caching from the ProjectBuilder
------------------------------------------

                 Key: MNG-2837
                 URL: http://jira.codehaus.org/browse/MNG-2837
             Project: Maven 2
          Issue Type: Task
    Affects Versions: 2.1-alpha-1
            Reporter: Jason van Zyl
             Fix For: 2.1-alpha-1


All the caching should be removed so that we can accurate measure the performance prior to optimization and place the caching where it belongs. The ProjectBuilder should only build projects and that's it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-2837) Remove all caching from the ProjectBuilder

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl closed MNG-2837.
------------------------------

    Resolution: Fixed

Yah, i consider this closed. Within the reactor you need some caching. What's important is that it's not in the project builder.

> Remove all caching from the ProjectBuilder
> ------------------------------------------
>
>                 Key: MNG-2837
>                 URL: http://jira.codehaus.org/browse/MNG-2837
>             Project: Maven 2
>          Issue Type: Task
>    Affects Versions: 2.1-alpha-1
>            Reporter: Jason van Zyl
>             Fix For: 2.1-alpha-1
>
>
> All the caching should be removed so that we can accurate measure the performance prior to optimization and place the caching where it belongs. The ProjectBuilder should only build projects and that's it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2837) Remove all caching from the ProjectBuilder

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl updated MNG-2837:
-------------------------------

    Fix Version/s: 2.1-alpha-1

> Remove all caching from the ProjectBuilder
> ------------------------------------------
>
>                 Key: MNG-2837
>                 URL: http://jira.codehaus.org/browse/MNG-2837
>             Project: Maven 2
>          Issue Type: Task
>    Affects Versions: 2.1-alpha-1
>            Reporter: Jason van Zyl
>             Fix For: 2.1-alpha-1
>
>
> All the caching should be removed so that we can accurate measure the performance prior to optimization and place the caching where it belongs. The ProjectBuilder should only build projects and that's it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2837) Remove all caching from the ProjectBuilder

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88070 ] 

John Casey commented on MNG-2837:
---------------------------------

I've removed caching from the project builder. However, project-instance caching is necessary for proper reactor functionality, so it's not possible to get a truly cache-less baseline like you're describing. What we have now is very close to a baseline for the project builder, I think.

BTW, the project cache is now tied to the current thread and its children via InheritableThreadLocal, so the cache should be garbage collected when the build completes.

> Remove all caching from the ProjectBuilder
> ------------------------------------------
>
>                 Key: MNG-2837
>                 URL: http://jira.codehaus.org/browse/MNG-2837
>             Project: Maven 2
>          Issue Type: Task
>    Affects Versions: 2.1-alpha-1
>            Reporter: Jason van Zyl
>             Fix For: 2.1-alpha-1
>
>
> All the caching should be removed so that we can accurate measure the performance prior to optimization and place the caching where it belongs. The ProjectBuilder should only build projects and that's it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira