You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/06 14:37:55 UTC

[GitHub] [shardingsphere] pjfanning opened a new pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

pjfanning opened a new pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266


   Fixes #15265.
   
   Changes proposed in this pull request:
   - pom change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] pjfanning commented on pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.

pjfanning commented on pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266#issuecomment-1030887241


   @terrymanu looks like maven-shade-plugin needs to be upgraded - I'm trying this in https://github.com/apache/shardingsphere/pull/15266/commits/b7f1c5afa90aca69ac5e532fd889126f97b3c9ad


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.

terrymanu commented on pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266#issuecomment-1030850722


   Please fix CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266#issuecomment-1030908474


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15266](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7f1c5a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/58138125b45b10065bcff8680bfe0aba37017cdd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5813812) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/15266/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #15266      +/-   ##
   ============================================
   - Coverage     60.22%   60.21%   -0.01%     
   + Complexity     1937     1933       -4     
   ============================================
     Files          3189     3187       -2     
     Lines         47665    47656       -9     
     Branches       8099     8099              
   ============================================
   - Hits          28705    28697       -8     
   - Misses        16639    16640       +1     
   + Partials       2321     2319       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ource/props/custom/CustomDataSourceProperties.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL2N1c3RvbS9DdXN0b21EYXRhU291cmNlUHJvcGVydGllcy5qYXZh) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [...re/spring/boot/datasource/DataSourceMapSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L2RhdGFzb3VyY2UvRGF0YVNvdXJjZU1hcFNldHRlci5qYXZh) | `48.14% <0.00%> (-5.19%)` | :arrow_down: |
   | [.../shardingsphere/spring/boot/util/PropertyUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L3V0aWwvUHJvcGVydHlVdGlsLmphdmE=) | `51.11% <0.00%> (-2.23%)` | :arrow_down: |
   | [...pool/metadata/type/DBCPDataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9EQkNQRGF0YVNvdXJjZVBvb2xNZXRhRGF0YS5qYXZh) | | |
   | [...etadata/type/TomcatDBCPDataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9Ub21jYXREQkNQRGF0YVNvdXJjZVBvb2xNZXRhRGF0YS5qYXZh) | | |
   | [.../impl/AbstractDbcp2DataSourcePropertiesSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L2RhdGFzb3VyY2UvcHJvcC9pbXBsL0Fic3RyYWN0RGJjcDJEYXRhU291cmNlUHJvcGVydGllc1NldHRlci5qYXZh) | | |
   | [...op/impl/CommonDbcp2DataSourcePropertiesSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L2RhdGFzb3VyY2UvcHJvcC9pbXBsL0NvbW1vbkRiY3AyRGF0YVNvdXJjZVByb3BlcnRpZXNTZXR0ZXIuamF2YQ==) | | |
   | [...op/impl/TomcatDbcp2DataSourcePropertiesSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L2RhdGFzb3VyY2UvcHJvcC9pbXBsL1RvbWNhdERiY3AyRGF0YVNvdXJjZVByb3BlcnRpZXNTZXR0ZXIuamF2YQ==) | | |
   | [...ce/prop/impl/DataSourcePropertiesSetterHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L2RhdGFzb3VyY2UvcHJvcC9pbXBsL0RhdGFTb3VyY2VQcm9wZXJ0aWVzU2V0dGVySG9sZGVyLmphdmE=) | | |
   | [...ol/metadata/type/HikariDataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9IaWthcmlEYXRhU291cmNlUG9vbE1ldGFEYXRhLmphdmE=) | | |
   | ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/15266/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5813812...b7f1c5a](https://codecov.io/gh/apache/shardingsphere/pull/15266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #15266: [issue-15265] upgrade to bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.

terrymanu commented on pull request #15266:
URL: https://github.com/apache/shardingsphere/pull/15266#issuecomment-1031012228


   Great job, thank you very much


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org