You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/06/20 11:48:07 UTC

[GitHub] [incubator-shenyu] KevinClair opened a new pull request #1654: [ISSUE #1653] Refactor Code about client register.

KevinClair opened a new pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654


   Feature #1653 
   * Use factory to refactor code about client register.
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://dromara.org/projects/soul/contributor/).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4d0803) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `2.65%`.
   > The diff coverage is `13.25%`.
   
   > :exclamation: Current head f4d0803 differs from pull request most recent head ffb8d61. Consider uploading reports for the commit ffb8d61 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   60.16%   -2.66%     
   - Complexity     2220     2228       +8     
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   + Hits           5997     6060      +63     
   - Misses         3057     3526     +469     
   + Partials        493      487       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] dengliming commented on a change in pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

dengliming commented on a change in pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#discussion_r654924692



##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/ShenyuClientRegisterSofaServiceImpl.java
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.service.register;
+
+import org.apache.shenyu.admin.listener.DataChangedEvent;
+import org.apache.shenyu.admin.mapper.MetaDataMapper;
+import org.apache.shenyu.admin.mapper.PluginMapper;
+import org.apache.shenyu.admin.mapper.RuleMapper;
+import org.apache.shenyu.admin.model.dto.SelectorDTO;
+import org.apache.shenyu.admin.model.entity.MetaDataDO;
+import org.apache.shenyu.admin.model.entity.PluginDO;
+import org.apache.shenyu.admin.model.entity.RuleDO;
+import org.apache.shenyu.admin.model.entity.SelectorDO;
+import org.apache.shenyu.admin.service.RuleService;
+import org.apache.shenyu.admin.service.SelectorService;
+import org.apache.shenyu.admin.transfer.MetaDataTransfer;
+import org.apache.shenyu.admin.utils.ShenyuResultMessage;
+import org.apache.shenyu.common.enums.ConfigGroupEnum;
+import org.apache.shenyu.common.enums.DataEventTypeEnum;
+import org.apache.shenyu.common.enums.PluginEnum;
+import org.apache.shenyu.common.utils.UUIDUtils;
+import org.apache.shenyu.register.common.dto.MetaDataRegisterDTO;
+import org.springframework.context.ApplicationEventPublisher;
+import org.springframework.stereotype.Service;
+
+import java.sql.Timestamp;
+import java.util.Collections;
+import java.util.Objects;
+
+/**
+ * sofa service register.
+ *
+ * @author KevinClair
+ **/
+@Service("sofa")
+public class ShenyuClientRegisterSofaServiceImpl extends AbstractShenyuClientRegisterService {
+
+    private final MetaDataMapper metaDataMapper;
+
+    private final ApplicationEventPublisher eventPublisher;
+
+    private final SelectorService selectorService;
+
+    private final RuleService ruleService;
+
+    private final RuleMapper ruleMapper;
+
+    private final PluginMapper pluginMapper;
+
+    public ShenyuClientRegisterSofaServiceImpl(final MetaDataMapper metaDataMapper,
+                                               final ApplicationEventPublisher eventPublisher,
+                                               final SelectorService selectorService,
+                                               final RuleService ruleService,
+                                               final RuleMapper ruleMapper,
+                                               final PluginMapper pluginMapper) {
+        this.metaDataMapper = metaDataMapper;
+        this.eventPublisher = eventPublisher;
+        this.selectorService = selectorService;
+        this.ruleService = ruleService;
+        this.ruleMapper = ruleMapper;
+        this.pluginMapper = pluginMapper;
+    }
+
+    @Override
+    public synchronized String register(final MetaDataRegisterDTO dto) {
+        MetaDataDO metaDataDO = metaDataMapper.findByPath(dto.getPath());
+        if (Objects.nonNull(metaDataDO)
+                && (!metaDataDO.getMethodName().equals(dto.getMethodName())
+                || !metaDataDO.getServiceName().equals(dto.getServiceName()))) {
+            return "you path already exist!";
+        }

Review comment:
       Can we add this part to `AbstractShenyuClientRegisterService`. Both sofa and tars can use it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffb8d61) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `3.40%`.
   > The diff coverage is `13.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.40%   -3.41%     
   + Complexity     2220     2215       -5     
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   - Hits           5997     5984      -13     
   - Misses         3057     3608     +551     
   + Partials        493      481      -12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158c980) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/ed0d6eb0f17e0408021f1214719ce2a5dacdd128?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed0d6eb) will **decrease** coverage by `2.15%`.
   > The diff coverage is `13.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.67%   60.52%   -2.16%     
   - Complexity     2215     2218       +3     
   ============================================
     Files           460      469       +9     
     Lines          9540     9881     +341     
     Branches        975      991      +16     
   ============================================
   + Hits           5979     5980       +1     
   - Misses         3064     3410     +346     
   + Partials        497      491       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...shenyu/admin/service/impl/MetaDataServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL01ldGFEYXRhU2VydmljZUltcGwuamF2YQ==) | `79.56% <0.00%> (-19.10%)` | :arrow_down: |
   | [...e/shenyu/admin/service/impl/PluginServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1BsdWdpblNlcnZpY2VJbXBsLmphdmE=) | `94.39% <0.00%> (-2.73%)` | :arrow_down: |
   | [...che/shenyu/admin/service/impl/RuleServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1J1bGVTZXJ2aWNlSW1wbC5qYXZh) | `72.94% <0.00%> (-2.67%)` | :arrow_down: |
   | [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `43.03% <0.00%> (-25.65%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.28% <12.28%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `14.89% <14.89%> (ø)` | |
   | ... and [25 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed0d6eb...158c980](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffb8d61) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `3.10%`.
   > The diff coverage is `13.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.71%   -3.11%     
     Complexity     2220     2220              
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   + Hits           5997     6015      +18     
   - Misses         3057     3570     +513     
   + Partials        493      488       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffb8d61) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `2.65%`.
   > The diff coverage is `13.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   60.16%   -2.66%     
   - Complexity     2220     2228       +8     
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   + Hits           5997     6060      +63     
   - Misses         3057     3526     +469     
   + Partials        493      487       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158c980) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/ed0d6eb0f17e0408021f1214719ce2a5dacdd128?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed0d6eb) will **decrease** coverage by `2.46%`.
   > The diff coverage is `13.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.67%   60.20%   -2.47%     
   + Complexity     2215     2213       -2     
   ============================================
     Files           460      469       +9     
     Lines          9540     9881     +341     
     Branches        975      991      +16     
   ============================================
   - Hits           5979     5949      -30     
   - Misses         3064     3444     +380     
   + Partials        497      488       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...shenyu/admin/service/impl/MetaDataServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL01ldGFEYXRhU2VydmljZUltcGwuamF2YQ==) | `79.56% <0.00%> (-19.10%)` | :arrow_down: |
   | [...e/shenyu/admin/service/impl/PluginServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1BsdWdpblNlcnZpY2VJbXBsLmphdmE=) | `94.39% <0.00%> (-2.73%)` | :arrow_down: |
   | [...che/shenyu/admin/service/impl/RuleServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1J1bGVTZXJ2aWNlSW1wbC5qYXZh) | `72.94% <0.00%> (-2.67%)` | :arrow_down: |
   | [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `43.03% <0.00%> (-25.65%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.28% <12.28%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `14.89% <14.89%> (ø)` | |
   | ... and [25 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed0d6eb...158c980](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

KevinClair commented on a change in pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#discussion_r654924230



##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/ShenyuClientRegisterTarsServiceImpl.java
##########
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.service.register;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.listener.DataChangedEvent;
+import org.apache.shenyu.admin.mapper.MetaDataMapper;
+import org.apache.shenyu.admin.mapper.PluginMapper;
+import org.apache.shenyu.admin.mapper.RuleMapper;
+import org.apache.shenyu.admin.mapper.SelectorMapper;
+import org.apache.shenyu.admin.model.dto.SelectorDTO;
+import org.apache.shenyu.admin.model.entity.MetaDataDO;
+import org.apache.shenyu.admin.model.entity.PluginDO;
+import org.apache.shenyu.admin.model.entity.RuleDO;
+import org.apache.shenyu.admin.model.entity.SelectorDO;
+import org.apache.shenyu.admin.service.RuleService;
+import org.apache.shenyu.admin.service.SelectorService;
+import org.apache.shenyu.admin.service.impl.UpstreamCheckService;
+import org.apache.shenyu.admin.transfer.MetaDataTransfer;
+import org.apache.shenyu.admin.utils.ShenyuResultMessage;
+import org.apache.shenyu.common.dto.SelectorData;
+import org.apache.shenyu.common.dto.convert.DivideUpstream;
+import org.apache.shenyu.common.enums.ConfigGroupEnum;
+import org.apache.shenyu.common.enums.DataEventTypeEnum;
+import org.apache.shenyu.common.enums.PluginEnum;
+import org.apache.shenyu.common.utils.GsonUtils;
+import org.apache.shenyu.common.utils.UUIDUtils;
+import org.apache.shenyu.register.common.dto.MetaDataRegisterDTO;
+import org.springframework.context.ApplicationEventPublisher;
+import org.springframework.stereotype.Service;
+
+import java.sql.Timestamp;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+
+/**
+ * tars service register.
+ *
+ * @author KevinClair

Review comment:
       : )got it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70baf72) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b65bb23b0217b3529979af10145aef1e7b285e71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b65bb23) will **decrease** coverage by `3.30%`.
   > The diff coverage is `13.28%`.
   
   > :exclamation: Current head 70baf72 differs from pull request most recent head c530997. Consider uploading reports for the commit c530997 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.72%   59.41%   -3.31%     
   + Complexity     2220     2219       -1     
   ============================================
     Files           460      469       +9     
     Lines          9547    10072     +525     
     Branches        976     1019      +43     
   ============================================
   - Hits           5988     5984       -4     
   - Misses         3063     3601     +538     
   + Partials        496      487       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `13.15% <13.15%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `17.02% <17.02%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b65bb23...c530997](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70baf72) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b65bb23b0217b3529979af10145aef1e7b285e71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b65bb23) will **decrease** coverage by `3.30%`.
   > The diff coverage is `13.28%`.
   
   > :exclamation: Current head 70baf72 differs from pull request most recent head c530997. Consider uploading reports for the commit c530997 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.72%   59.41%   -3.31%     
   + Complexity     2220     2219       -1     
   ============================================
     Files           460      469       +9     
     Lines          9547    10072     +525     
     Branches        976     1019      +43     
   ============================================
   - Hits           5988     5984       -4     
   - Misses         3063     3601     +538     
   + Partials        496      487       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `13.15% <13.15%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `17.02% <17.02%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b65bb23...c530997](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158c980) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/ed0d6eb0f17e0408021f1214719ce2a5dacdd128?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed0d6eb) will **decrease** coverage by `1.93%`.
   > The diff coverage is `13.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.67%   60.74%   -1.94%     
   - Complexity     2215     2221       +6     
   ============================================
     Files           460      469       +9     
     Lines          9540     9881     +341     
     Branches        975      991      +16     
   ============================================
   + Hits           5979     6002      +23     
   - Misses         3064     3391     +327     
   + Partials        497      488       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...shenyu/admin/service/impl/MetaDataServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL01ldGFEYXRhU2VydmljZUltcGwuamF2YQ==) | `79.56% <0.00%> (-19.10%)` | :arrow_down: |
   | [...e/shenyu/admin/service/impl/PluginServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1BsdWdpblNlcnZpY2VJbXBsLmphdmE=) | `94.39% <0.00%> (-2.73%)` | :arrow_down: |
   | [...che/shenyu/admin/service/impl/RuleServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1J1bGVTZXJ2aWNlSW1wbC5qYXZh) | `72.94% <0.00%> (-2.67%)` | :arrow_down: |
   | [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `43.03% <0.00%> (-25.65%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.28% <12.28%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `14.89% <14.89%> (ø)` | |
   | ... and [22 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed0d6eb...158c980](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f05b20) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `2.73%`.
   > The diff coverage is `13.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   60.07%   -2.74%     
   - Complexity     2220     2228       +8     
   ============================================
     Files           460      469       +9     
     Lines          9547    10072     +525     
     Branches        976     1019      +43     
   ============================================
   + Hits           5997     6051      +54     
   - Misses         3057     3530     +473     
   + Partials        493      491       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `13.15% <13.15%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `17.02% <17.02%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...9f05b20](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4d0803) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `2.88%`.
   > The diff coverage is `13.25%`.
   
   > :exclamation: Current head f4d0803 differs from pull request most recent head ffb8d61. Consider uploading reports for the commit ffb8d61 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.93%   -2.89%     
   - Complexity     2220     2225       +5     
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   + Hits           5997     6037      +40     
   - Misses         3057     3551     +494     
   + Partials        493      485       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] dengliming commented on a change in pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

dengliming commented on a change in pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#discussion_r654923746



##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/AbstractShenyuClientRegisterService.java
##########
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.service.register;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.model.dto.RuleConditionDTO;
+import org.apache.shenyu.admin.model.dto.RuleDTO;
+import org.apache.shenyu.admin.model.dto.SelectorConditionDTO;
+import org.apache.shenyu.admin.model.dto.SelectorDTO;
+import org.apache.shenyu.admin.model.entity.MetaDataDO;
+import org.apache.shenyu.common.dto.convert.DivideUpstream;
+import org.apache.shenyu.common.dto.convert.rule.RuleHandle;
+import org.apache.shenyu.common.dto.convert.rule.RuleHandleFactory;
+import org.apache.shenyu.common.enums.MatchModeEnum;
+import org.apache.shenyu.common.enums.OperatorEnum;
+import org.apache.shenyu.common.enums.ParamTypeEnum;
+import org.apache.shenyu.common.enums.PluginEnum;
+import org.apache.shenyu.common.enums.SelectorTypeEnum;
+import org.apache.shenyu.register.common.dto.MetaDataRegisterDTO;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Abstract strategy.
+ *
+ * @author KevinClair
+ **/
+public abstract class AbstractShenyuClientRegisterService implements ShenyuClientRegisterServiceFactory {

Review comment:
       What about `AbstractShenyuClientRegisterServiceImpl implements ShenyuClientRegisterService`？

##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/ShenyuClientRegisterTarsServiceImpl.java
##########
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.service.register;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.listener.DataChangedEvent;
+import org.apache.shenyu.admin.mapper.MetaDataMapper;
+import org.apache.shenyu.admin.mapper.PluginMapper;
+import org.apache.shenyu.admin.mapper.RuleMapper;
+import org.apache.shenyu.admin.mapper.SelectorMapper;
+import org.apache.shenyu.admin.model.dto.SelectorDTO;
+import org.apache.shenyu.admin.model.entity.MetaDataDO;
+import org.apache.shenyu.admin.model.entity.PluginDO;
+import org.apache.shenyu.admin.model.entity.RuleDO;
+import org.apache.shenyu.admin.model.entity.SelectorDO;
+import org.apache.shenyu.admin.service.RuleService;
+import org.apache.shenyu.admin.service.SelectorService;
+import org.apache.shenyu.admin.service.impl.UpstreamCheckService;
+import org.apache.shenyu.admin.transfer.MetaDataTransfer;
+import org.apache.shenyu.admin.utils.ShenyuResultMessage;
+import org.apache.shenyu.common.dto.SelectorData;
+import org.apache.shenyu.common.dto.convert.DivideUpstream;
+import org.apache.shenyu.common.enums.ConfigGroupEnum;
+import org.apache.shenyu.common.enums.DataEventTypeEnum;
+import org.apache.shenyu.common.enums.PluginEnum;
+import org.apache.shenyu.common.utils.GsonUtils;
+import org.apache.shenyu.common.utils.UUIDUtils;
+import org.apache.shenyu.register.common.dto.MetaDataRegisterDTO;
+import org.springframework.context.ApplicationEventPublisher;
+import org.springframework.stereotype.Service;
+
+import java.sql.Timestamp;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+
+/**
+ * tars service register.
+ *
+ * @author KevinClair

Review comment:
       Let's remove `@author` : )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] dengliming merged pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

dengliming merged pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

KevinClair commented on a change in pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#discussion_r654924407



##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/AbstractShenyuClientRegisterService.java
##########
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.admin.service.register;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.model.dto.RuleConditionDTO;
+import org.apache.shenyu.admin.model.dto.RuleDTO;
+import org.apache.shenyu.admin.model.dto.SelectorConditionDTO;
+import org.apache.shenyu.admin.model.dto.SelectorDTO;
+import org.apache.shenyu.admin.model.entity.MetaDataDO;
+import org.apache.shenyu.common.dto.convert.DivideUpstream;
+import org.apache.shenyu.common.dto.convert.rule.RuleHandle;
+import org.apache.shenyu.common.dto.convert.rule.RuleHandleFactory;
+import org.apache.shenyu.common.enums.MatchModeEnum;
+import org.apache.shenyu.common.enums.OperatorEnum;
+import org.apache.shenyu.common.enums.ParamTypeEnum;
+import org.apache.shenyu.common.enums.PluginEnum;
+import org.apache.shenyu.common.enums.SelectorTypeEnum;
+import org.apache.shenyu.register.common.dto.MetaDataRegisterDTO;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Abstract strategy.
+ *
+ * @author KevinClair
+ **/
+public abstract class AbstractShenyuClientRegisterService implements ShenyuClientRegisterServiceFactory {

Review comment:
       OK, I will modify the name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f05b20) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `3.19%`.
   > The diff coverage is `13.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.62%   -3.20%     
   - Complexity     2220     2222       +2     
   ============================================
     Files           460      469       +9     
     Lines          9547    10072     +525     
     Branches        976     1019      +43     
   ============================================
   + Hits           5997     6005       +8     
   - Misses         3057     3578     +521     
   + Partials        493      489       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `13.15% <13.15%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `17.02% <17.02%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...9f05b20](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4d0803) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `3.38%`.
   > The diff coverage is `13.25%`.
   
   > :exclamation: Current head f4d0803 differs from pull request most recent head ffb8d61. Consider uploading reports for the commit ffb8d61 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.42%   -3.39%     
   + Complexity     2220     2216       -4     
   ============================================
     Files           460      469       +9     
     Lines          9547    10073     +526     
     Branches        976     1021      +45     
   ============================================
   - Hits           5997     5986      -11     
   - Misses         3057     3605     +548     
   + Partials        493      482      -11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [.../register/AbstractShenyuClientRegisterService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `2.08% <2.08%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `12.82% <12.82%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `16.32% <16.32%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...ffb8d61](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1654: [ISSUE #1653] Refactor Code about client register.

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1654:
URL: https://github.com/apache/incubator-shenyu/pull/1654#issuecomment-864543100


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1654](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f05b20) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/9011e97465e574d7e69691eb7251f7766b5f2099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9011e97) will **decrease** coverage by `3.40%`.
   > The diff coverage is `13.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1654      +/-   ##
   ============================================
   - Coverage     62.81%   59.41%   -3.41%     
   + Complexity     2220     2216       -4     
   ============================================
     Files           460      469       +9     
     Lines          9547    10072     +525     
     Branches        976     1019      +43     
   ============================================
   - Hits           5997     5984      -13     
   - Misses         3057     3601     +544     
   + Partials        493      487       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...enyu/admin/config/RegisterCenterConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL1JlZ2lzdGVyQ2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...in/disruptor/RegisterServerDisruptorPublisher.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyU2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `85.71% <ø> (ø)` | |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.96% <1.96%> (ø)` | |
   | [...ster/ShenyuClientRegisterSpringMVCServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ01WQ1NlcnZpY2VJbXBsLmphdmE=) | `11.11% <11.11%> (ø)` | |
   | [...er/ShenyuClientRegisterSpringCloudServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNwcmluZ0Nsb3VkU2VydmljZUltcGwuamF2YQ==) | `12.30% <12.30%> (ø)` | |
   | [.../register/ShenyuClientRegisterTarsServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclRhcnNTZXJ2aWNlSW1wbC5qYXZh) | `13.15% <13.15%> (ø)` | |
   | [.../register/ShenyuClientRegisterGrpcServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckdycGNTZXJ2aWNlSW1wbC5qYXZh) | `13.69% <13.69%> (ø)` | |
   | [...register/ShenyuClientRegisterMotanServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3Rlck1vdGFuU2VydmljZUltcGwuamF2YQ==) | `13.69% <13.69%> (ø)` | |
   | [.../register/ShenyuClientRegisterSofaServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNvZmFTZXJ2aWNlSW1wbC5qYXZh) | `17.02% <17.02%> (ø)` | |
   | [...register/ShenyuClientRegisterDubboServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlckR1YmJvU2VydmljZUltcGwuamF2YQ==) | `18.60% <18.60%> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9011e97...9f05b20](https://codecov.io/gh/apache/incubator-shenyu/pull/1654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org