You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/27 09:50:29 UTC
Review Request 57950: Reordered messages in 'acls.proto'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57950/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Vinod Kone.
Repository: mesos
Description
-------
See https://reviews.apache.org/r/57386/#comment240626 for more details.
Diffs
-----
include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b
Diff: https://reviews.apache.org/r/57950/diff/1/
Testing
-------
Thanks,
Gast�n Kleiman
Re: Review Request 57950: Reordered messages in 'acls.proto'.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57950/#review170150
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On March 27, 2017, 11:50 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57950/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 11:50 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/57386/#comment240626 for more details.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b
>
>
> Diff: https://reviews.apache.org/r/57950/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 57950: Reordered messages in 'acls.proto'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57950/#review170153
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57950]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 27, 2017, 9:50 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57950/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:50 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/57386/#comment240626 for more details.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b
>
>
> Diff: https://reviews.apache.org/r/57950/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 57950: Reordered messages in 'acls.proto'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57950/#review170152
-----------------------------------------------------------
Fix it, then Ship it!
I'll fix the issue while committing.
include/mesos/authorizer/acls.proto
Lines 404 (patched)
<https://reviews.apache.org/r/57950/#comment242940>
This is not an enum : )
include/mesos/authorizer/acls.proto
Lines 409-411 (original), 410-412 (patched)
<https://reviews.apache.org/r/57950/#comment242941>
@arojas, isn't it time : )?
- Alexander Rukletsov
On March 27, 2017, 9:50 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57950/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:50 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/57386/#comment240626 for more details.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b
>
>
> Diff: https://reviews.apache.org/r/57950/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gast�n Kleiman
>
>