[GitHub] [flink] godfreyhe commented on a change in pull request #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#discussion_r302866103
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/batch/sql/SinkTest.scala
 ##########
 @@ -60,4 +67,25 @@ class SinkTest extends TableTestBase {
     util.verifyPlan()
   }
 
+  @Test
+  def testCatalogTableSink(): Unit = {
 
 Review comment:
   actually, I find that the following simplified test will throw `NoMatchingTableFactoryException` before this PR, so I think this test case can be simplified.
   ```
     @Test
     def testCatalogTableSink(): Unit = {
       val schemaBuilder = new TableSchema.Builder()
       schemaBuilder.fields(Array("i"), Array(DataTypes.INT()))
       val schema = schemaBuilder.build()
       val catalog = util.tableEnv.getCatalog(util.tableEnv.getCurrentCatalog).get()
       val catalogTable = new CatalogTableImpl(schema, Map[String, String]().asJava, "")
       catalog.createTable(new ObjectPath("default_database", "tbl"), catalogTable, false)
       util.tableEnv.sqlQuery("select 1").insertInto("tbl")
       util.tableEnv.explain(false)
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services