You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2018/10/19 13:30:00 UTC
[jira] [Closed] (FLINK-10608) Add avro files generated by
datastream-allround-test to RAT exclusions
[ https://issues.apache.org/jira/browse/FLINK-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-10608.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.7.0
1.6.3
master: 657fa5c9561f21e7286d4b1577354fcccc7edf9d
1.6: 85bb8fea508a9d0904ded569ee877c8a5347a3b7
> Add avro files generated by datastream-allround-test to RAT exclusions
> ----------------------------------------------------------------------
>
> Key: FLINK-10608
> URL: https://issues.apache.org/jira/browse/FLINK-10608
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.6.1, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.3, 1.7.0
>
>
> With the 1.5.5 and 1.6.2 release-candidates it was discovered that files generated during the build are not covered by the {{apache-rat-plugin}} license-header check.
> As a result the first compilation succeeds but a subsequent one may fail.
> -This is a bit surprising considering that the plugin is executed in the verify phase, which is executed after the compilation and execution of tests.-
> This is because the plugin is only run in the {{flink-parent}} project before anything is compiled. The plugin-configuration is explicitly disables inheritance.
> I'm re-purposing this Jira to add the avro classes to the exclusion list.
> However, in the long term I'd suggest to enable inheritance for the plugin and define the module-specific exclusions in each module respectively. This will allows to run the plugin in the verify phase of each module which would've caught this error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)