You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/10 02:50:52 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #6845: [HUDI-4945] Add a test case for batch clean.

danny0405 commented on code in PR #6845:
URL: https://github.com/apache/hudi/pull/6845#discussion_r990886072


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -323,32 +323,41 @@ void testStreamWriteReadSkippingCompaction() throws Exception {
     assertRowsEquals(rows, TestData.DATA_SET_SOURCE_INSERT_LATEST_COMMIT);
   }
 
-  @Test
-  void testStreamWriteWithCleaning() {
-    // create filesystem table named source
-
-    // the source generates 4 commits but the cleaning task
-    // would always try to keep the remaining commits number as 1
-    String createSource = TestConfigurations.getFileSourceDDL(

Review Comment:
   Can we add a new test case instead of modifying existing one ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org