You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:59:32 UTC

[GitHub] [incubator-nuttx-apps] gustavonihei opened a new pull request #624: fsutils/mksmartfs: Fix regression caused by BCH separation

gustavonihei opened a new pull request #624:
URL: https://github.com/apache/incubator-nuttx-apps/pull/624


   ## Summary
   This PR intends to fix regression caused by PR [3061](https://github.com/apache/incubator-nuttx/pull/3061), which separated the BCH login from CONFIG_DISABLE_MOUNTPOINT.
   Since the Block-to-character driver is not built by default, `mksmartfs` fails to open the file descriptor of the MTD block device.
   
   ## Impact
   Fix `mksmartfs` NSH command on targets that support SMARTFS file system.
   
   ## Testing
   `esp32-devkic:spiflash` and also on custom configuration for `sim`
   `fstest` also executed to completion
   Previous behavior:
   ```shell
   Shell (NSH) NuttX-10.0.1
   nsh> mksmartfs /dev/smart0
   nsh: mksmartfs: mksmartfs failed: 2
   nsh> 
   ```
   With proposed change:
   ```shell
   NuttShell (NSH) NuttX-10.0.1
   nsh> mksmartfs /dev/smart0
   nsh> 
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #624: fsutils/mksmartfs: Fix regression caused by BCH separation

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #624:
URL: https://github.com/apache/incubator-nuttx-apps/pull/624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org