You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 09:00:49 UTC
[GitHub] [spark] LuciferYang opened a new pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
LuciferYang opened a new pull request #32232:
URL: https://github.com/apache/spark/pull/32232
### What changes were proposed in this pull request?
`WritablePartitionedIterator` define in `WritablePartitionedPairCollection.scala` and there are two implementation of these trait, but the code for these two implementations is duplicate.
The main change of this pr is extract a class implementation of `WritablePartitionedIterator` to remove these duplicate code.
### Why are the changes needed?
Cleanup duplicate code.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the Jenkins or GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r617342481
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
I think we can just turn the trait into the class if there's only one implementation now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r618069694
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
turn the trait into the class will fail MiMa tests:
```
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.0.0! Found 1 potential problems (filtered 1184)
[error] * declaration of interface org.apache.spark.util.collection.WritablePartitionedIterator is class org.apache.spark.util.collection.WritablePartitionedIterator in current version; changing interface to class breaks client code
[error] filter with: ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.util.collection.WritablePartitionedIterator")
```
Can you give me some guidance on how to solve this problem? @Ngone51 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826250995
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42427/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r615668834
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
Is there any suggestion for a better class name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828344365
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42558/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826250995
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42427/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826258296
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r618069694
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
turn the trait into the class will fail MiMa tests:
```
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.0.0! Found 1 potential problems (filtered 1184)
[error] * declaration of interface org.apache.spark.util.collection.WritablePartitionedIterator is class org.apache.spark.util.collection.WritablePartitionedIterator in current version; changing interface to class breaks client code
[error] filter with: ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.util.collection.WritablePartitionedIterator")
...
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.0.0! Found 1 potential problems (filtered 1184)
[error] * declaration of interface org.apache.spark.util.collection.WritablePartitionedIterator is class org.apache.spark.util.collection.WritablePartitionedIterator in current version; changing interface to class breaks client code
[error] filter with: ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.util.collection.WritablePartitionedIterator")
```
Can you give me some guidance on how to solve this problem? @Ngone51 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r618036277
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
ok ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824523116
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42294/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822534419
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137620/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826250995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826258296
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826238292
**[Test build #137902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137902/testReport)** for PR 32232 at commit [`8835ecc`](https://github.com/apache/spark/commit/8835ecc657ac43747b2fca56800eb58e2449d3f2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828416293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138039/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826238292
**[Test build #137902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137902/testReport)** for PR 32232 at commit [`8835ecc`](https://github.com/apache/spark/commit/8835ecc657ac43747b2fca56800eb58e2449d3f2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824522508
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r619760870
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
3215b1e add a `IncompatibleTemplateDefProblem` exclude filter to `MimaExcludes.scala`, GA passed now. @Ngone51 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822377782
**[Test build #137620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137620/testReport)** for PR 32232 at commit [`b46ea28`](https://github.com/apache/spark/commit/b46ea28fc65a7b8fa03dd24e1318ba9d78b46c48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828309862
**[Test build #138039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138039/testReport)** for PR 32232 at commit [`2c59eef`](https://github.com/apache/spark/commit/2c59eefc5a7979b16479a38f5df3cce14584cdba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822914172
cc @Ngone51 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828416293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138039/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822385724
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42151/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822516453
**[Test build #137620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137620/testReport)** for PR 32232 at commit [`b46ea28`](https://github.com/apache/spark/commit/b46ea28fc65a7b8fa03dd24e1318ba9d78b46c48).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828404198
**[Test build #138039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138039/testReport)** for PR 32232 at commit [`2c59eef`](https://github.com/apache/spark/commit/2c59eefc5a7979b16479a38f5df3cce14584cdba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r619760870
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
8835ecc add a `IncompatibleTemplateDefProblem` exclude filter to `MimaExcludes.scala`, GA passed now. @Ngone51 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824505270
**[Test build #137766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137766/testReport)** for PR 32232 at commit [`313d75f`](https://github.com/apache/spark/commit/313d75f9d7a27864063d8e4b14a74933a2de59ea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824510745
**[Test build #137766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137766/testReport)** for PR 32232 at commit [`313d75f`](https://github.com/apache/spark/commit/313d75f9d7a27864063d8e4b14a74933a2de59ea).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828920706
Thanks, merged to Master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828347003
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42558/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822534419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826249590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828309862
**[Test build #138039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138039/testReport)** for PR 32232 at commit [`2c59eef`](https://github.com/apache/spark/commit/2c59eefc5a7979b16479a38f5df3cce14584cdba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-823734643
@Ngone51 Do you have time to review this pr ? thx ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824523116
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42294/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822385701
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42151/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826250995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824523100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 closed pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
Ngone51 closed pull request #32232:
URL: https://github.com/apache/spark/pull/32232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826238292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828347003
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42558/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826238292
**[Test build #137902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137902/testReport)** for PR 32232 at commit [`8835ecc`](https://github.com/apache/spark/commit/8835ecc657ac43747b2fca56800eb58e2449d3f2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824522508
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-828905813
thx ~ @HyukjinKwon @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r619760870
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
8835ecc add a `IncompatibleTemplateDefProblem` exclude filter to `MimaExcludes.scala`, GA passed now. @Ngone51 @HyukjinKwon
##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])
Review comment:
3215b1e add a `IncompatibleTemplateDefProblem` exclude filter to `MimaExcludes.scala`, GA passed now. @Ngone51 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822381440
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42151/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-826257417
**[Test build #137902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137902/testReport)** for PR 32232 at commit [`8835ecc`](https://github.com/apache/spark/commit/8835ecc657ac43747b2fca56800eb58e2449d3f2).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MiscellaneousProcessDetails(`
* `case class SparkListenerMiscellaneousProcessAdded(time: Long, processId: String,`
* ` case class MiscellaneousProcessAdded(`
* `class ImmutableBitSet(val numBits: Int, val bitsToSet: Int*) extends BitSet(numBits) `
* ` case class CombinedTypeCoercionRule(rules: Seq[TypeCoercionRule]) extends TypeCoercionRule `
* `case class DomainJoin(domainAttrs: Seq[Attribute], child: LogicalPlan) extends UnaryNode `
* `abstract class CustomSumMetric extends CustomMetric `
* `abstract class CustomAvgMetric extends CustomMetric `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-822377782
**[Test build #137620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137620/testReport)** for PR 32232 at commit [`b46ea28`](https://github.com/apache/spark/commit/b46ea28fc65a7b8fa03dd24e1318ba9d78b46c48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32232: [SPARK-35135][CORE] Extract a class implementation of `WritablePartitionedIterator` to remove duplicate code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32232:
URL: https://github.com/apache/spark/pull/32232#issuecomment-824505270
**[Test build #137766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137766/testReport)** for PR 32232 at commit [`313d75f`](https://github.com/apache/spark/commit/313d75f9d7a27864063d8e4b14a74933a2de59ea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org