You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/11 17:45:03 UTC

[GitHub] [superset] codecov[bot] commented on pull request #24663: fix(dataset-import): support empty strings for extra fields

codecov[bot] commented on PR #24663:
URL: https://github.com/apache/superset/pull/24663#issuecomment-1631238553

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24663](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ff1c135) into [master](https://app.codecov.io/gh/apache/superset/commit/4881328fbf5615ed24884de0f92aba28e0836c31?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4881328) will **decrease** coverage by `10.87%`.
   > The diff coverage is `65.00%`.
   
   > :exclamation: Current head ff1c135 differs from pull request most recent head daa89ef. Consider uploading reports for the commit daa89ef to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #24663       +/-   ##
   ===========================================
   - Coverage   69.05%   58.19%   -10.87%     
   ===========================================
     Files        1907     1907               
     Lines       74151    74157        +6     
     Branches     8182     8177        -5     
   ===========================================
   - Hits        51204    43152     -8052     
   - Misses      20824    28885     +8061     
   + Partials     2123     2120        -3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `54.03% <0.00%> (-0.01%)` | :arrow_down: |
   | python | `60.82% <100.00%> (-22.67%)` | :arrow_down: |
   | unit | `54.83% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Icons/Icon.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `0.00% <ø> (ø)` | |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `9.09% <0.00%> (ø)` | |
   | [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `46.96% <0.00%> (ø)` | |
   | [.../src/explore/components/ControlPanelsContainer.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `69.76% <0.00%> (ø)` | |
   | [...features/annotationLayers/AnnotationLayerModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Fubm90YXRpb25MYXllcnMvQW5ub3RhdGlvbkxheWVyTW9kYWwudHN4) | `58.97% <ø> (ø)` | |
   | [...ntend/src/features/annotations/AnnotationModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Fubm90YXRpb25zL0Fubm90YXRpb25Nb2RhbC50c3g=) | `50.98% <ø> (ø)` | |
   | [...end/src/features/cssTemplates/CssTemplateModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2Nzc1RlbXBsYXRlcy9Dc3NUZW1wbGF0ZU1vZGFsLnRzeA==) | `56.09% <ø> (ø)` | |
   | [...ntend/src/SqlLab/components/TableElement/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC9pbmRleC50c3g=) | `81.17% <33.33%> (-0.76%)` | :arrow_down: |
   | [...-frontend/src/components/DeprecatedSelect/utils.ts](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVwcmVjYXRlZFNlbGVjdC91dGlscy50cw==) | `50.00% <50.00%> (+8.33%)` | :arrow_up: |
   | [...plugins/plugin-chart-echarts/src/utils/controls.ts](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvY29udHJvbHMudHM=) | `75.00% <100.00%> (ø)` | |
   | ... and [5 more](https://app.codecov.io/gh/apache/superset/pull/24663?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [298 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24663/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org