You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/09/06 16:51:14 UTC

[GitHub] [openwhisk] rabbah commented on a change in pull request #4611: Factor out subjects view name for identities

rabbah commented on a change in pull request #4611: Factor out subjects view name for identities
URL: https://github.com/apache/openwhisk/pull/4611#discussion_r321821839
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Identity.scala
 ##########
 @@ -129,10 +131,12 @@ object Identity extends MultipleReadersSingleWriterCache[Option[Identity], DocIn
       stale = StaleParameter.No)
   }
 
-  private def rowToIdentity(row: JsObject, key: String)(implicit transid: TransactionId, logger: Logging) = {
+  protected[entity] def rowToIdentity(row: JsObject, key: String)(implicit transid: TransactionId, logger: Logging) = {
 
 Review comment:
   added a unit test for this method (there was a bug in the one of the test helper methods).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services