[jira] [Commented] (CASSANDRA-6630) counters++ handle duplicate cells in a mutation

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885516#comment-13885516 ] 

Sylvain Lebresne commented on CASSANDRA-6630:
---------------------------------------------

Took me 3 minutes to understand what the hell this was about and that this was about UnsortedColumns not properly merging cells having the same name. I don't think we should work around that by adding complexity but rather than we should avoid UnsortedColumns in those code path.

In fact, now that AtomicBTreeColumns actually expect the added ColumnFamily to be sorted (and explicitly sort it if it's UnsortedColumns), I'm not sure there is any benefits to keeping UnsortedColumns around. It would in fact probably be more efficient in general to create things sorted once on the coordinator rather than explicitly sorting it on every replica at the beginning of AtomicBTreeColumns.addAllWithSizeDelta.

> counters++ handle duplicate cells in a mutation
> -----------------------------------------------
>
>                 Key: CASSANDRA-6630
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6630
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.1
>
>         Attachments: 6630.txt
>
>
> It's possible for a counter mutation to have several CounterUpdateCell-s with the same cell name. Those should be summed up and not ignored.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)