You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/02/24 03:24:29 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1362: refactor(conf): use DSN_DEFINE_double to load double type of configs
acelyc111 opened a new pull request, #1362:
URL: https://github.com/apache/incubator-pegasus/pull/1362
https://github.com/apache/incubator-pegasus/issues/1323
This patch refactors the code to use `DSN_DEFINE_uint64` instead of `dsn_config_get_value_uint64` to load uint64 type of configurations, and doesn't introduce any functional changes.
- all default value and most of description are kept as before
- move the defination of flags closer to the places where they're used
- rename `num` and `seed` to `benchmark_num` and `benchmark_seed` in section `[pegasus.benchmark]`, it's acceptable because they're just in benchmark tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1362: refactor(conf): use DSN_DEFINE_double to load double type of configs
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1362:
URL: https://github.com/apache/incubator-pegasus/pull/1362#discussion_r1116472308
##########
src/runtime/service_api_c.cpp:
##########
@@ -50,6 +50,15 @@
#include "utils/time_utils.h"
#include "utils/process_utils.h"
+#ifdef DSN_ENABLE_GPERF
+DSN_DEFINE_double(core,
+ tcmalloc_release_rate,
+ 1.,
+ "the memory releasing rate of tcmalloc, default "
+ "is 1.0 in gperftools, value range is "
+ "[0.0~10.0]");
Review Comment:
```suggestion
"[0.0, 10.0]");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1362: refactor(conf): use DSN_DEFINE_double to load double type of configs
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #1362:
URL: https://github.com/apache/incubator-pegasus/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org