You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by om...@apache.org on 2019/06/22 03:22:06 UTC
[orc] branch master updated: ORC-518: Ignore findbugs false
positives from jdk11.
This is an automated email from the ASF dual-hosted git repository.
omalley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/master by this push:
new 4139b8d ORC-518: Ignore findbugs false positives from jdk11.
4139b8d is described below
commit 4139b8d0ce681eab1eafeca641df04bc793bc4ae
Author: Owen O'Malley <om...@apache.org>
AuthorDate: Fri Jun 21 10:05:03 2019 -0700
ORC-518: Ignore findbugs false positives from jdk11.
Fixes #404
Signed-off-by: Owen O'Malley <om...@apache.org>
---
java/core/src/findbugs/exclude.xml | 7 +++++++
java/tools/src/findbugs/exclude.xml | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/java/core/src/findbugs/exclude.xml b/java/core/src/findbugs/exclude.xml
index 1f079cb..a78dda7 100644
--- a/java/core/src/findbugs/exclude.xml
+++ b/java/core/src/findbugs/exclude.xml
@@ -31,4 +31,11 @@
<Bug pattern="MS_PKGPROTECT"/>
<Class name="org.apache.orc.impl.RecordReaderImpl$SargApplier"/>
</Match>
+ <!-- Java's try with resources causes a false positive.
+ See https://github.com/SERG-Delft/jpacman/pull/27 . -->
+ <Match>
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+ <Class name="org.apache.orc.impl.OrcAcidUtils"/>
+ <Method name="getLastFlushLength"/>
+ </Match>
</FindBugsFilter>
diff --git a/java/tools/src/findbugs/exclude.xml b/java/tools/src/findbugs/exclude.xml
index fd215c0..be94306 100644
--- a/java/tools/src/findbugs/exclude.xml
+++ b/java/tools/src/findbugs/exclude.xml
@@ -16,4 +16,11 @@
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2,DM_EXIT"/>
</Match>
+ <!-- Java's try with resources causes a false positive.
+ See https://github.com/SERG-Delft/jpacman/pull/27 . -->
+ <Match>
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
+ <Class name="org.apache.orc.tools.PrintVersion"/>
+ <Method name="main"/>
+ </Match>
</FindBugsFilter>