You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/05 15:31:53 UTC

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4620: Checkstyle: Add Checkstyle Rule to prevent Map and Set

RussellSpitzer commented on code in PR #4620:
URL: https://github.com/apache/iceberg/pull/4620#discussion_r866043179


##########
core/src/main/java/org/apache/iceberg/util/StructLikeMap.java:
##########
@@ -104,7 +104,7 @@ public void clear() {
   }
 
   @Override
-  public Set<StructLike> keySet() {

Review Comment:
   This is the change I think we need to revert, I get worried about changing the public api of this class. I think just suppressing the rule for this usage is fine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org