[GitHub] [incubator-apisix] spacewander opened a new issue #816: bug: should not remove the square brackets of [IPv6] address literal in core.utils.parse_addr

[GitBox <gi...@apache.org>]

spacewander opened a new issue #816: bug: should not remove the square brackets of [IPv6] address literal in core.utils.parse_addr
URL: https://github.com/apache/incubator-apisix/issues/816
 
 
   Currently I choice to remove the square brackets because `core.utils.parse_ipv6` doesn't work if the square brackets are kept.
   
   However, the OpenResty APIs (tcpsock:connect, balancer.set_current_peer, etc.) require the square brackets in the IPv6 address even though they are used without the port part. Admittedly, it would be better to fix in the OpenResty APIs side, but these APIs are created and widely adopted long time ago...
   
   Therefore, to make the IPv6 upstream work, we need to keep the square brackets too. My proposal is modifying `core.utils.parse_addr` not to remove the brackets, and changing `core.utils.parse_ipv6` to accept the brackets.
   
   What about your opinion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services