You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 03:54:13 UTC

[GitHub] [airflow] mik-laj commented on pull request #13446: Add docker health check to integrations

mik-laj commented on pull request #13446:
URL: https://github.com/apache/airflow/pull/13446#issuecomment-753743192


   > But I would like to understand a bit more how the values for retries are determined , especially it varies quite much among different cases. For example, for mysql it is 120, which may be too big to me.
   
   This value was copied from the internet. All health checks in` integration-*. xml` files have identical configuration.
   ```
         interval: 5s
         timeout: 30s
         retries: 50
   ```
   interval 5s - breeze is used by users so make it responsive. timeout 30s has no reason whatsoever, but that makes sense to me. retries 50 is is the value copied from (in-container health checks)[https://github.com/apache/airflow/blob/6ef23aff802032e85ec42dabda83907bfd812b2c/scripts/in_container/check_environment.sh#L158-L174]. This value was determined experimentally and so far I have the impression that it works.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org