[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4319: HIVE-25366: Reduce number of Table calls in updatePartitonColStatsInt…

["dengzhhu653 (via GitHub)" <gi...@apache.org>]

dengzhhu653 commented on code in PR #4319:
URL: https://github.com/apache/hive/pull/4319#discussion_r1199544150


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -4109,7 +4110,7 @@ private List<Partition> add_partitions_core(final RawStore ms, String catName,
             + TableName.getQualified(catName, dbName, tblName) +
             " does not exist");
       }
-
+      MTable mTable = getMS().ensureGetMTable(catName, dbName, tblName);

Review Comment:
   nit: could we use something like `ObjectStore.convertToMTable` to get a `MTable` from `tbl` instance? For example, adding a  `MetaStoreServerUtils.convertToMTable(RawStore, Table)` instead of introducing the `ensureGetMTable` API in `RawStore`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org