You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/27 13:02:00 UTC

[jira] [Work logged] (HIVE-24691) Ban commons-logging (again)

     [ https://issues.apache.org/jira/browse/HIVE-24691?focusedWorklogId=542810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542810 ]

ASF GitHub Bot logged work on HIVE-24691:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/21 13:01
            Start Date: 27/Jan/21 13:01
    Worklog Time Spent: 10m 
      Work Description: zmatyus opened a new pull request #1916:
URL: https://github.com/apache/hive/pull/1916


   ### What changes were proposed in this pull request?
   
   Replace org.apache.commons.logging with org.slf4j and prevent it from being reintroduced.
   
   ### Why are the changes needed?
   
   I encountered HIVE-24636, a memory leak related to commons-logging. I either had to fix the leak on master, or remove commons-logging. Since HIVE-20019 already removed commons-logging, it just got reintroduced later, I chose the latter.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 542810)
    Remaining Estimate: 0h
            Time Spent: 10m

> Ban commons-logging (again)
> ---------------------------
>
>                 Key: HIVE-24691
>                 URL: https://issues.apache.org/jira/browse/HIVE-24691
>             Project: Hive
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 4.0.0
>            Reporter: Zoltan Matyus
>            Assignee: Zoltan Matyus
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The usage of commons-logging has been completely removed once from Hive in HIVE-20019. However, new usage has been added since, despite attempts to ban this (bannedDependencies). I'm removing all usage again, and add another way to ban using it (restrictImports).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)