You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/10/13 22:29:53 UTC
[Bug 57081] New: Updating checkstyle to only check for tabs in java
files (and not images!)
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Bug ID: 57081
Summary: Updating checkstyle to only check for tabs in java
files (and not images!)
Product: JMeter
Version: Nightly (Please specify date)
Hardware: PC
OS: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: jmeter@ham1.co.uk
Created attachment 32104
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32104&action=edit
Code patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Mon Oct 13 21:02:22 2014
New Revision: 1631549
URL: http://svn.apache.org/r1631549
Log:
Bug 57081 - Updating checkstyle to only check for tabs in java files (and not
images!)
Bugzilla Id: 57081
Modified:
jmeter/trunk/checkstyle.xml
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
CC| |p.mouawad@ubik-ingenierie.c
| |om
Component|HTTP |Main
Hardware|PC |All
OS|Linux |All
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java, xml,
xsd, dtd, htm, html and txt files (not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Updating checkstyle to only |Updating checkstyle to only
|check for tabs in java, |check for tabs in java,
|xml, xsd, xls, dtd, htm, |xml, xsd, dtd, htm, html
|html and txt files (not |and txt files (not images!)
|images!) |
--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Oct 18 13:49:29 2014
New Revision: 1632791
URL: http://svn.apache.org/r1632791
Log:
Bug 57081 - Updating checkstyle to only check for tabs in java, xml, xsd, xls,
dtd, htm, html and txt files (not images!)
Avoid xls
Bugzilla Id: 57081
Modified:
jmeter/trunk/checkstyle.xml
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
--- Comment #4 from Sebb <se...@apache.org> ---
(In reply to Graham from comment #3)
> Created attachment 32112 [details]
> Update to include more file formats
This is better, but the problem with the inclusion method is that new text file
types will not be caught. Also there are several text file types that have been
omitted (e.g. .properties, .rdf, README)
I think it would be better to exclude binary types.
There are probably fewer of those, and any omissions will be obvious as
checkstyle will complain.
Whereas omitted inclusions won't provide any indication.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
--- Comment #6 from Sebb <se...@apache.org> ---
(In reply to Graham Russell from comment #5)
> Unfortunately checkstyle doesn't appear to allow exclusions only inclusions
> (it might be possible using an external 'suppressions' config file but that
> seems a little much).
http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#excludes
> I'd prefer not to have false positives but potentially miss tabs in other
> obscure text files. Are tabs so evil in these other documents?
False positives can easily be fixed.
> On a slightly separate note, do people use this checkstyle config? It does
> seem to have a lot of things commented out and not be very big, could we
> perhaps use it more and include more things?
That is a subject for the developer list.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #2 from Sebb <se...@apache.org> ---
Tabs are also deprecated in other text files such as xml, .txt etc.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java, xml,
xsd, xls, dtd, htm, html and txt files (not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Updating checkstyle to only |Updating checkstyle to only
|check for tabs in java |check for tabs in java,
|files (and not images!) |xml, xsd, xls, dtd, htm,
| |html and txt files (not
| |images!)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java, xml,
xsd, xls, dtd, htm, html and txt files (not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Oct 18 12:53:34 2014
New Revision: 1632783
URL: http://svn.apache.org/r1632783
Log:
Bug 57081 - Updating checkstyle to only check for tabs in java, xml, xsd, xls,
dtd, htm, html and txt files (not images!)
Bugzilla Id: 57081
Modified:
jmeter/trunk/checkstyle.xml
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
--- Comment #3 from Graham <jm...@ham1.co.uk> ---
Created attachment 32112
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32112&action=edit
Update to include more file formats
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57081] Updating checkstyle to only check for tabs in java files
(and not images!)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57081
--- Comment #5 from Graham Russell <jm...@ham1.co.uk> ---
Unfortunately checkstyle doesn't appear to allow exclusions only inclusions (it
might be possible using an external 'suppressions' config file but that seems a
little much).
I'd prefer not to have false positives but potentially miss tabs in other
obscure text files. Are tabs so evil in these other documents?
On a slightly separate note, do people use this checkstyle config? It does seem
to have a lot of things commented out and not be very big, could we perhaps use
it more and include more things?
FYI here is a list of all the file extensions JM currently has:
all
bat
bsh
bshrc
cgi
cmd
conf
css
csv
dtd
fb
fdl
gif
htm
html
idx
jar
java
jmx
jpg
jsp
jtl
license
MF
notice
odt
pack
parameters
pdf
png
pom
properties
providers
rdf
readme
sample
set
sh
svg
sxi
sxw
tsv
txt
vsl
xcf
xml
xsd
xsl
--
You are receiving this mail because:
You are the assignee for the bug.