You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/13 15:49:01 UTC

[GitHub] [flink] dannycranmer commented on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards

dannycranmer commented on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898556384


   LGTM, thanks @elphastori. Will merge once e2e tests pass
   
   ✅  1. The [description] looks good.
   ✅  2. There is [consensus] that the contribution should go into to Flink.
   ✅  3. Needs [attention] from. N/A
   ✅  4. The change fits into the overall [architecture].
   ✅  5. Overall code [quality] is good.
   ✅  6. License check N/A
   ⏲️   7. E2e tests pass
   ✅  8. Commit contains the Jira ID


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org