You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/05/18 10:03:14 UTC

[GitHub] [cordova-plugin-inappbrowser] erisu opened a new pull request, #946: fix(android): increase toolbar to 48dp

erisu opened a new pull request, #946:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/946

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   - android
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Follow the Material Design Guidelines for touch targets size requirements.
   
   >   "For most platforms, consider making touch targets at least 48 x 48dp."
   
   Google Play will report a warning that the close button does not meet the requirement.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   - The current close button size is 58dp width, 44dp height.
   - This PR increases the toolbar area space to 48dp, which in effect increases the close button to 48dp.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   - build app and confirm increase height.
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] erisu merged pull request #946: fix(android): increase toolbar to 48dp

Posted by GitBox <gi...@apache.org>.
erisu merged PR #946:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/946


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org