You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/01 09:17:47 UTC
[GitHub] [dubbo-go] jyz0309 opened a new pull request, #1875: Use summary type to observe p99
jyz0309 opened a new pull request, #1875:
URL: https://github.com/apache/dubbo-go/pull/1875
Signed-off-by: jyz0309 <45...@qq.com>
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
Change metric type to observe RT P99 value.
**Which issue(s) this PR fixes**:
None.
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [ ] All ut passed (run 'go test ./...' in project root)
- [ ] After go-fmt ed , run 'go fmt project' using goland.
- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] jyz0309 commented on a diff in pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
jyz0309 commented on code in PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#discussion_r862480838
##########
metrics/prometheus/reporter.go:
##########
@@ -78,9 +78,9 @@ func init() {
// https://prometheus.io/docs/guides/go-application/
type PrometheusReporter struct {
// report the consumer-side's rt gauge data
- consumerRTGaugeVec *prometheus.GaugeVec
+ consumerRTGaugeVec *prometheus.SummaryVec
Review Comment:
Done. PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] jyz0309 commented on pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
jyz0309 commented on PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#issuecomment-1118680357
> Good， and it's better to add Max Age configuration at https://github.com/apache/dubbo-go/pull/1875/files#diff-dabf5562f4d32b8bc69d22e50f651690c48257c90f56f7104cde9fc014af1cd3R217
>
> The sdk: https://github.com/prometheus/client_golang/blob/fa4aa9000d2863904891d193dea354d23f3d712a/prometheus/summary.go#L207
>
> and export the configuration to dubbogo.yaml , metrics config struct of root config.
>
> @jyz0309
Can you tell me how to export configuration to dubbogo.yaml? It will help a lot if there is a sample code. @LaurenceLiZhixin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#issuecomment-1118136039
Good， and it's better to add Max Age configuration at
https://github.com/apache/dubbo-go/pull/1875/files#diff-dabf5562f4d32b8bc69d22e50f651690c48257c90f56f7104cde9fc014af1cd3R217
and export the configuration to dubbogo.yaml , metrics config struct of root config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] pherzheyu commented on a diff in pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
pherzheyu commented on code in PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#discussion_r862455191
##########
metrics/prometheus/reporter.go:
##########
@@ -78,9 +78,9 @@ func init() {
// https://prometheus.io/docs/guides/go-application/
type PrometheusReporter struct {
// report the consumer-side's rt gauge data
- consumerRTGaugeVec *prometheus.GaugeVec
+ consumerRTGaugeVec *prometheus.SummaryVec
Review Comment:
consumerRTGaugeVec名称修改下or新增一个新的字段？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#issuecomment-1120122657
Add a config field named "RTSummaryMaxAge" of metrics config here: https://github.com/apache/dubbo-go/blob/master/config/metric_config.go#L31
And set this config field to your summary.
@jyz0309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1875: Use summary type to observe p99
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1875:
URL: https://github.com/apache/dubbo-go/pull/1875#issuecomment-1114184204
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1875](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (873c193) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/759a9b5f864afa51130c43bc3c7b040ddf5b03a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (759a9b5) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 3.0 #1875 +/- ##
==========================================
+ Coverage 46.87% 46.98% +0.10%
==========================================
Files 298 297 -1
Lines 17178 17294 +116
==========================================
+ Hits 8053 8126 +73
- Misses 8272 8307 +35
- Partials 853 861 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `32.57% <100.00%> (+4.00%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <0.00%> (-13.34%)` | :arrow_down: |
| [remoting/xds/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcveGRzL2NsaWVudC5nbw==) | `52.94% <0.00%> (-3.95%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
| [remoting/xds/ewatcher/ewatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcveGRzL2V3YXRjaGVyL2V3YXRjaGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [xds/client/bootstrap/bootstrap.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-eGRzL2NsaWVudC9ib290c3RyYXAvYm9vdHN0cmFwLmdv) | `59.11% <0.00%> (ø)` | |
| [xds/balancer/clusterimpl/picker.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-eGRzL2JhbGFuY2VyL2NsdXN0ZXJpbXBsL3BpY2tlci5nbw==) | `0.00% <0.00%> (ø)` | |
| [xds/balancer/ringhash/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-eGRzL2JhbGFuY2VyL3JpbmdoYXNoL2xvZ2dpbmcuZ28=) | | |
| [xds/balancer/clusterimpl/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-eGRzL2JhbGFuY2VyL2NsdXN0ZXJpbXBsL2xvZ2dpbmcuZ28=) | | |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/1875/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [759a9b5...873c193](https://codecov.io/gh/apache/dubbo-go/pull/1875?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org