You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/11/21 19:50:27 UTC
Re: Review Request 38932: Kill health check external command process
and continue check after timeout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/#review107497
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 5, 2015, 10:18 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38932/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 10:18 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3479
> https://issues.apache.org/jira/browse/MESOS-3479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Kill health check external command process and continue check after timeout.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
> src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
>
> Diff: https://reviews.apache.org/r/38932/diff/
>
>
> Testing
> -------
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose
>
>
> Thanks,
>
> haosdent huang
>
>