You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2023/05/12 20:14:00 UTC
[jira] [Resolved] (YUNIKORN-1732) Build fails due to brittle SHA calculation
[ https://issues.apache.org/jira/browse/YUNIKORN-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Condit resolved YUNIKORN-1732.
------------------------------------
Fix Version/s: 1.3.0
Resolution: Fixed
Merged to master.
> Build fails due to brittle SHA calculation
> ------------------------------------------
>
> Key: YUNIKORN-1732
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1732
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
> Reporter: Craig Condit
> Assignee: Craig Condit
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> When building the k8shim, the script used to calculate the SHA of various components is inconsistent and can fail the build if the SI or core are replaced with local components.
> {noformat}
> ./scripts/plugin-conf-gen.sh /Users/ccondit/.kube/config "conf/scheduler-config.yaml" "conf/scheduler-config-local.yaml"
> building binary for scheduler docker image
> CGO_ENABLED=0 GOOS=linux GOARCH="amd64" \
> go build -a -o=_output/bin/k8s_yunikorn_scheduler -ldflags \
> '-extldflags "-static" -X main.version=latest -X main.date=2023-05-11T16:04:37-0500 -X main.goVersion=1.20.2 -X main.arch=amd64 -X main.coreSHA=20230328135225 -X main.siSHA=interface v0.0.0 -X main.shimSHA=0935a47ee430' \
> -tags netgo -installsuffix netgo \
> ./pkg/cmd/shim/
> # github.com/apache/yunikorn-k8shim/pkg/cmd/shim
> usage: link [options] main.o
> ...
> make: *** [scheduler] Error 1
> command execution failed: build docker images failed
> {noformat}
> The problematic portion:
> {noformat}
> -X main.coreSHA=20230328135225
> -X main.siSHA=interface v0.0.0
> -X main.shimSHA=0935a47ee430
> {noformat}
> The output is inconsistent, and in the case of the SI SHA, contains a space.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org