You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/09 16:10:14 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1677: Fix generate_unions_case for Rust case

viirya commented on code in PR #1677:
URL: https://github.com/apache/arrow-rs/pull/1677#discussion_r868183199


##########
arrow/src/datatypes/datatype.rs:
##########
@@ -499,6 +499,52 @@ impl DataType {
                         ))
                     }
                 }
+                Some(s) if s == "union" => {

Review Comment:
   We don't parse union type from json before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org