You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/05 03:45:21 UTC

[GitHub] [incubator-kyuubi] iodone opened a new pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

iodone opened a new pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   Fixes #1678
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Updating `hasResultSet` state which is determined by the remote service
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] iodone commented on a change in pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
iodone commented on a change in pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#discussion_r778583573



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -69,6 +69,7 @@ class ExecuteStatement(
       // in thrift protocol, in sync mode, we cannot distinguish between long-run query and
       // engine crash without response before socket read timeout.
       _remoteOpHandle = client.executeStatement(statement, true, queryTimeout)
+      setHasResultSet(_remoteOpHandle.isHasResultSet)

Review comment:
       https://github.com/apache/incubator-kyuubi/blob/e0d9458144e68411f1dd62afb91efd1e1ef92cc5/kyuubi-common/src/main/scala/org/apache/kyuubi/service/ThriftBinaryFrontendService.scala#L415-L437
   
   There is a unified configuration inside `GetOperationStatus` method, here we only need to change the operation's state
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#issuecomment-1005433995


   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#issuecomment-1005410822


   Seems test failed due to the flink memory issue, can you retrigger the GA @iodone thanks?
   
   ```java
   FlinkOperationSuite:
   Starting cluster.
   Starting standalonesession daemon on host fv-az212-351.
   Starting taskexecutor daemon on host fv-az212-351.
   ./build/mvn: line 118:  1840 Killed                  ${MVN_BIN} $MAVEN_CLI_OPTS "$@"
   ```
   
   also cc @yanghua


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#discussion_r778569688



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -69,6 +69,7 @@ class ExecuteStatement(
       // in thrift protocol, in sync mode, we cannot distinguish between long-run query and
       // engine crash without response before socket read timeout.
       _remoteOpHandle = client.executeStatement(statement, true, queryTimeout)
+      setHasResultSet(_remoteOpHandle.isHasResultSet)

Review comment:
       Shall we also update it according to TGetOperationStatusResp in waitStatementComplete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#issuecomment-1005411331


   I'm finding the solution to reduce flink cluster memory usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#issuecomment-1005425222


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1682](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e55385) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e0d9458144e68411f1dd62afb91efd1e1ef92cc5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0d9458) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1682   +/-   ##
   =========================================
     Coverage     59.56%   59.56%           
     Complexity      193      193           
   =========================================
     Files           265      265           
     Lines         13088    13089    +1     
     Branches       1648     1648           
   =========================================
   + Hits           7796     7797    +1     
     Misses         4637     4637           
     Partials        655      655           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e0d9458...8e55385](https://codecov.io/gh/apache/incubator-kyuubi/pull/1682?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org