You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/10 18:10:22 UTC

[GitHub] [superset] geido opened a new issue #14555: [Dashboard] The popover menu does not show when selecting a text component

geido opened a new issue #14555:
URL: https://github.com/apache/superset/issues/14555


   When editing a dashboard, the popover menu for text-based components is not showing up
   
   ### Expected results
   
   When editing a dashboard and selecting a text component, the popover menu should show up
   
   ### Actual results
   
   It does not show up
   
   #### Screenshots
   
   <img width="710" alt="Screen Shot 2021-05-10 at 21 07 35" src="https://user-images.githubusercontent.com/60598000/117704828-faddfc80-b1d3-11eb-8be6-3d941c21cbc1.png">
   
   <img width="831" alt="Screen Shot 2021-05-10 at 21 08 15" src="https://user-images.githubusercontent.com/60598000/117704859-04676480-b1d4-11eb-8c30-1600d8a19109.png">
   
   
   #### How to reproduce the bug
   
   1. Go to a dashboard and enable the edit mode
   2. Click on a text component
   3. The popover menu does not appear
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-839718872


   @pkdotson I am going to tackle this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-837266165


   thanks for reporting! 
   looks like edit menu is missing in multiple places 
   expected behavior 
   <img width="1789" alt="Screen Shot 2021-05-10 at 1 13 37 PM" src="https://user-images.githubusercontent.com/67837651/117718919-a0bc4780-b191-11eb-9b03-3a8b0d14561e.png">
   now seeing
   <img width="1791" alt="Screen Shot 2021-05-10 at 1 14 55 PM" src="https://user-images.githubusercontent.com/67837651/117719786-ac5c3e00-b192-11eb-82ea-0eb3c1b4cd90.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-837073701


   @junlincc @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-840867827


   Agreed. Closing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-840416112


   @junlincc @rusackas this now looks resolved on master
   
   https://www.awesomescreenshot.com/video/3727489?key=956839d019ff263f990addb8a6f32b07


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-837266165


   thanks for reporting! 
   looks like edit menu is missing in multiple places 
   expected behavior 
   <img width="1789" alt="Screen Shot 2021-05-10 at 1 13 37 PM" src="https://user-images.githubusercontent.com/67837651/117718919-a0bc4780-b191-11eb-9b03-3a8b0d14561e.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian closed issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
suddjian closed issue #14555:
URL: https://github.com/apache/superset/issues/14555


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14555: [Dashboard] The popover menu does not show when selecting a text component

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14555:
URL: https://github.com/apache/superset/issues/14555#issuecomment-838627684


   For clarity, what this issue is reporting specifically is the missing popover menu for text components. I have forced it to show it in the screenshot below. It seems the position is messed up
   
   <img width="710" alt="Screen Shot 2021-05-10 at 21 07 35" src="https://user-images.githubusercontent.com/60598000/117837499-2b7c6f80-b282-11eb-9d3a-35f78a67f37c.png">
   
   This issue instead #14554 is reporting the problem with the missing row actions, which I think is what @junlincc  is referring to in the comment above
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org