You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/05/08 22:31:54 UTC
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/62
CB-8987: Support for save and remove for Windows 10
This change adds save and remove support to the contacts plugin when running on Windows 10. When the functionality isn't available on older platforms, the original behavior is retained.
The remove function is noteworthy because of the architectural way that Windows returns "aggregate" contacts when going through the global contacts list; it means the app has to find the app's part of the contact. If the contact doesn't belong to the app, it can't be deleted.
This also adds a manual test to remove the contact which is added (Dooney Evans) in the manual adding test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-8987
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 959fffad4a1e7c27b16478b24cdc628200d718d4
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-05-08T20:19:25Z
CB-8987: Support for save and remove for Windows 10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-100388932
Will run tests on medic, since Travis doesn't run the tests on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101766786
LGTM.
I'm sure Dooney Evans would approve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101757332
Ping.... Can I get a merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org