You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by GitBox <gi...@apache.org> on 2019/02/25 09:24:45 UTC
[GitHub] atsticks commented on issue #27: TAMAYA-379: Enforce checkstyle
rules
atsticks commented on issue #27: TAMAYA-379: Enforce checkstyle rules
URL: https://github.com/apache/incubator-tamaya-extensions/pull/27#issuecomment-466937862
Just for info: the method names map directly to the Shell commands in the
Gogo shell...
Am Di., 22. Jan. 2019, 05:59 hat Aaron Coburn <no...@github.com>
geschrieben:
> There are three categories of changes here:
>
> - Tabs change to spaces
> - Unused imports are removed
> - StarImports are replaced with explicit imports
> - Missing JavaDocs are added
>
> I made one modification to the checkstyle rules so that the existing
> method names in the gogo-shell module pass the MethodName check. These
> methods tend to follow this pattern: tm_propertysources, tm_apply_config,
> etc. (Another possibility would be to add a corresponding suppression,
> specific to the gogo-shell module for this pattern, or we could change the
> method names to follow more typical conventions).
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/incubator-tamaya-extensions/pull/27
> Commit Summary
>
> - TAMAYA-379: Enforce checkstyle rules
>
> File Changes
>
> - *M* buildtools/src/main/resources/checkstyle/style.xml
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-0>
> (2)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/CollectionConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-1>
> (3)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/ConcurrentHashMapConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-2>
> (3)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/HashSetConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-3>
> (3)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/LinkedListConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-4>
> (3)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/ListConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-5>
> (1)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/SortedSetConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-6>
> (2)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/TreeMapConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-7>
> (3)
> - *M*
> modules/collections/src/main/java/org/apache/tamaya/collections/TreeSetConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-8>
> (3)
> - *M*
> modules/consul/src/main/java/org/apache/tamaya/consul/ConsulBackendConfig.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-9>
> (4)
> - *M*
> modules/consul/src/main/java/org/apache/tamaya/consul/ConsulPropertySource.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-10>
> (12)
> - *M*
> modules/etcd/src/main/java/org/apache/tamaya/etcd/EtcdBackendConfig.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-11>
> (6)
> - *M*
> modules/etcd/src/main/java/org/apache/tamaya/etcd/EtcdPropertySource.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-12>
> (2)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/ConfigEventManager.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-13>
> (6)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/ConfigurationChangeBuilder.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-14>
> (1)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/FrozenConfiguration.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-15>
> (7)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-16>
> (1)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigEventManagerSpi.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-17>
> (4)
> - *M*
> modules/events/src/main/java/org/apache/tamaya/events/spi/ConfigEventManagerSpi.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-18>
> (2)
> - *M*
> modules/formats/base/src/main/java/org/apache/tamaya/format/BaseFormatPropertySourceProvider.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-19>
> (1)
> - *M*
> modules/formats/base/src/main/java/org/apache/tamaya/format/ConfigurationFormats.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-20>
> (1)
> - *M*
> modules/formats/base/src/main/java/org/apache/tamaya/format/MappedConfigurationDataPropertySource.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-21>
> (1)
> - *M*
> modules/formats/yaml/src/main/java/org/apache/tamaya/yaml/YAMLFormat.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-22>
> (3)
> - *M*
> modules/functions/src/main/java/org/apache/tamaya/functions/EnrichedConfiguration.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-23>
> (4)
> - *M*
> modules/functions/src/main/java/org/apache/tamaya/functions/PropertySourceFunctions.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-24>
> (2)
> - *M*
> modules/injection/cdi/src/main/java/org/apache/tamaya/cdi/ConfigurationProducer.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-25>
> (21)
> - *M*
> modules/injection/cdi/src/main/java/org/apache/tamaya/cdi/TamayaCDIInjectionExtension.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-26>
> (11)
> - *M*
> modules/injection/cdi/src/main/java/org/apache/tamaya/cdi/TamayaSEInjectionExtension.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-27>
> (6)
> - *M*
> modules/injection/injection-api/src/main/java/org/apache/tamaya/inject/spi/BaseDynamicValue.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-28>
> (1)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/ConfigTemplateInvocationHandler.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-29>
> (1)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/ConfiguredFieldImpl.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-30>
> (1)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/ConfiguredTypeImpl.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-31>
> (1)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/DefaultConfigurationInjector.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-32>
> (1)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/DefaultDynamicValue.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-33>
> (8)
> - *M*
> modules/injection/standalone/src/main/java/org/apache/tamaya/inject/internal/InjectionHelper.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-34>
> (1)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/MicroprofileAdapter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-35>
> (4)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/MicroprofileConfig.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-36>
> (5)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/MicroprofileConfigBuilder.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-37>
> (44)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/MicroprofileConfigProviderResolver.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-38>
> (4)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/MicroprofileConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-39>
> (1)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/TamayaConfiguration.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-40>
> (4)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/TamayaPropertyConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-41>
> (1)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/cdi/BridgingConfigBean.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-42>
> (2)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/cdi/ConfiguredType.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-43>
> (2)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/cdi/MicroprofileConfigurationProducer.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-44>
> (4)
> - *M*
> modules/microprofile/src/main/java/org/apache/tamaya/microprofile/converter/ProviderConverter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-45>
> (11)
> - *M*
> modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-46>
> (1)
> - *M*
> modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationProvider.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-47>
> (1)
> - *M*
> modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/propertysources/MutablePropertiesPropertySource.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-48>
> (5)
> - *M*
> modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/propertysources/MutableXmlPropertiesPropertySource.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-49>
> (5)
> - *M*
> modules/osgi/common/src/main/java/org/apache/tamaya/osgi/Activator.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-50>
> (5)
> - *M*
> modules/osgi/common/src/main/java/org/apache/tamaya/osgi/Backups.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-51>
> (2)
> - *M*
> modules/osgi/common/src/main/java/org/apache/tamaya/osgi/ConfigChanger.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-52>
> (9)
> - *M*
> modules/osgi/common/src/main/java/org/apache/tamaya/osgi/ConfigHistory.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-53>
> (3)
> - *M*
> modules/osgi/common/src/main/java/org/apache/tamaya/osgi/TamayaConfigPlugin.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-54>
> (16)
> - *M*
> modules/osgi/gogo-shell/src/main/java/org/apache/tamaya/gogo/shell/BackupCommands.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-55>
> (5)
> - *M*
> modules/osgi/gogo-shell/src/main/java/org/apache/tamaya/gogo/shell/ConfigCommands.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-56>
> (5)
> - *M*
> modules/osgi/gogo-shell/src/main/java/org/apache/tamaya/gogo/shell/HistoryCommands.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-57>
> (5)
> - *M*
> modules/osgi/gogo-shell/src/main/java/org/apache/tamaya/gogo/shell/SettingsCommands.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-58>
> (5)
> - *M*
> modules/osgi/injection/src/main/java/org/apache/tamaya/osgi/injection/Activator.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-59>
> (9)
> - *M*
> modules/osgi/injection/src/main/java/org/apache/tamaya/osgi/injection/TamayaOSGIInjector.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-60>
> (1)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/ApplyTamayaConfigCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-61>
> (6)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/BackupCreateCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-62>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/BackupDeleteCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-63>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/BackupListCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-64>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/BackupRestoreCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-65>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/DefaultEnableCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-66>
> (8)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/DefaultEnabledCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-67>
> (8)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/GetPolicyCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-68>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/HistoryDeleteAllCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-69>
> (6)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/HistoryDeleteCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-70>
> (9)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/HistoryGetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-71>
> (14)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/HistoryMaxsizeCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-72>
> (8)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/HistoryMaxsizeSetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-73>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/InfoCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-74>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/OSGIConfigCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-75>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PolicyGetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-76>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PolicySetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-77>
> (8)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PropagateUpdatesCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-78>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PropagateUpdatesSetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-79>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PropertyGetCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-80>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PropertySourceCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-81>
> (5)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/PropertySourcesCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-82>
> (8)
> - *M*
> modules/osgi/karaf-shell/src/main/java/org/apache/tamaya/karaf/shell/TamayaConfigCommand.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-83>
> (5)
> - *M*
> modules/osgi/updater/src/main/java/org/apache/tamaya/osgi/updater/Activator.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-84>
> (4)
> - *M*
> modules/osgi/updater/src/main/java/org/apache/tamaya/osgi/updater/EventListener.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-85>
> (3)
> - *M*
> modules/resolver/src/main/java/org/apache/tamaya/resolver/internal/ExpressionResolutionFilter.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-86>
> (6)
> - *M*
> modules/resolver/src/main/java/org/apache/tamaya/resolver/internal/FileResolver.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-87>
> (4)
> - *M*
> modules/resolver/src/main/java/org/apache/tamaya/resolver/internal/URLResolver.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-88>
> (3)
> - *M*
> modules/resources/src/main/java/org/apache/tamaya/resource/AbstractPathPropertySourceProvider.java
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-89>
> (5)
> - *M* pom.xml
> <https://github.com/apache/incubator-tamaya-extensions/pull/27/files#diff-90>
> (1)
>
> Patch Links:
>
> - https://github.com/apache/incubator-tamaya-extensions/pull/27.patch
> - https://github.com/apache/incubator-tamaya-extensions/pull/27.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-tamaya-extensions/pull/27>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AC5sc-w9T6kGiyqyJnjjaBspyGaW8Wluks5vFprMgaJpZM4aL72U>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services