You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/08 20:22:24 UTC

[GitHub] [beam] ibzib commented on a change in pull request #14941: [BEAM-12439] Reuse Java job servers in spark_runner.py.

ibzib commented on a change in pull request #14941:
URL: https://github.com/apache/beam/pull/14941#discussion_r647766699



##########
File path: sdks/python/apache_beam/runners/portability/spark_runner.py
##########
@@ -49,7 +53,15 @@ def default_job_server(self, options):
         raise ValueError('Option spark_rest_url must be set.')
       return spark_uber_jar_job_server.SparkUberJarJobServer(
           spark_options.spark_rest_url, options)
-    return job_server.StopOnExitJobServer(SparkJarJobServer(options))
+    # Use Java job server by default.
+    # Only SparkRunnerOptions and JobServerOptions affect job server

Review comment:
       I added an assertion for that in the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org