You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2026/04/22 16:21:08 UTC
(sling-whiteboard) 01/03: feat(skill_evals): another parent pom update case (simple)
This is an automated email from the ASF dual-hosted git repository.
rombert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-whiteboard.git
commit 092e31dbbaee8bd1dad1a5f431bc796e92a0f5b4
Author: Robert Munteanu <ro...@apache.org>
AuthorDate: Wed Apr 22 15:45:03 2026 +0200
feat(skill_evals): another parent pom update case (simple)
---
skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl | 3 ++-
skill-evals/src/skill_evals/jcr_js_nodetypes/task.py | 5 ++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl b/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl
index 33a1c824..dc55984b 100644
--- a/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl
+++ b/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl
@@ -1 +1,2 @@
-{"id":"upgrade-parent-pom","input":"Update to parent pom version {expected_parent_version}","git_revision":"52cea70b190c8389495a4fa494161eac13416891","expected_parent_version":"23"}
+{"id":"upgrade-parent-pom-{expected_parent_version}","input":"Update to parent pom version {expected_parent_version}","git_revision":"52cea70b190c8389495a4fa494161eac13416891","expected_parent_version":"23"}
+{"id":"upgrade-parent-pom-{expected_parent_version}","input":"Update to parent pom version {expected_parent_version}","git_revision":"84554fffb6c46bf48bb1856a6e60852127f57bcd","expected_parent_version":"24"}
diff --git a/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py b/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py
index 4cf79f0d..10bfc94b 100644
--- a/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py
+++ b/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py
@@ -28,9 +28,12 @@ def _record_to_sample(record: dict, *, skill_enabled: bool) -> Sample:
"git_revision": record["git_revision"],
"expected_parent_version": record["expected_parent_version"],
}
+ sample_id = record.get("id", "upgrade-parent-pom-{expected_parent_version}").format(
+ **metadata
+ )
return Sample(
- id=record.get("id"),
+ id=sample_id,
input=record["input"].format(**metadata),
metadata=metadata,
files={"/workspace/eval-assets/setup.sh": str(_task_dir() / "setup.sh")},