[GitHub] dongeforever commented on a change in pull request #606: Handle TODO

[GitBox <gi...@apache.org>]

dongeforever commented on a change in pull request #606: Handle TODO
URL: https://github.com/apache/rocketmq/pull/606#discussion_r242385939
 
 

 ##########
 File path: acl/src/main/java/org/apache/rocketmq/acl/plain/RemoteAddressStrategyFactory.java
 ##########
 @@ -32,8 +32,10 @@ public RemoteAddressStrategy getRemoteAddressStrategy(PlainAccessResource plainA
     }
 
     public RemoteAddressStrategy getRemoteAddressStrategy(String remoteAddr) {
-        //TODO if the white addr is not configured, should reject it.
-        if (StringUtils.isBlank(remoteAddr) || "*".equals(remoteAddr)) {
+        if (StringUtils.isBlank(remoteAddr)) {
+            throw new AclException("Must fill in the white list address");
 
 Review comment:
   Here should not throw exception. Null white address is allowed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services