You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/23 07:19:56 UTC

[GitHub] [incubator-druid] gianm commented on issue #8903: S3 input source

gianm commented on issue #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#issuecomment-557774609
 
 
   > I noticed that the type of this is `s3` (vs `static-s3`). I am 👍 on the change but should there be a release notes tag? My auto firehose to input source converter got caught out by this.
   
   @vogievetsky — "auto firehose to input source converter" sounds a bit scary, I don't think special effort was put into making the sources consistent with the firehoses (rather, I believe the effort was instead put into making them consistent _with other input sources_). So there may be other pitfalls if you are assuming they can be converted without special knowledge of the specific source type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org