You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/09 11:54:34 UTC
[GitHub] [tvm] pfk-beta opened a new pull request, #11243: [docs] fix link in `Handle TVM Errors` page
pfk-beta opened a new pull request, #11243:
URL: https://github.com/apache/tvm/pull/11243
On `Handle TVM Errors` there was broken link to `Error Handling Guide`. And IMHO there was missing, but obvious information about logging and verbosity. Changed negative information to positive feedback for potential TVM users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #11243: [docs] fix link in `Handle TVM Errors` page
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #11243:
URL: https://github.com/apache/tvm/pull/11243#discussion_r877910472
##########
docs/errors.rst:
##########
@@ -34,27 +34,37 @@ these error messages and what you can do when they occur.
Where do these errors come from?
--------------------------------
-This error is caused by an internal invariant being violated during TVM's
-execution. On a technical level, the message is generated by the
-``ICHECK`` macro, found in ``include/tvm/runtime/logging.h``.
+TVM is complex system, so errors may come from many places, and may inference
+other errors. Most of the errors comes from runtime enviroment. From technical
Review Comment:
typo
inference -> interfere?
enviroment -> environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #11243: [docs] fix link in `Handle TVM Errors` page
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #11243:
URL: https://github.com/apache/tvm/pull/11243#discussion_r877912719
##########
docs/errors.rst:
##########
@@ -34,27 +34,37 @@ these error messages and what you can do when they occur.
Where do these errors come from?
--------------------------------
-This error is caused by an internal invariant being violated during TVM's
-execution. On a technical level, the message is generated by the
-``ICHECK`` macro, found in ``include/tvm/runtime/logging.h``.
+TVM is complex system, so errors may come from many places, and may inference
+other errors. Most of the errors comes from runtime enviroment. From technical
+point of view, the message is generated by the ``ICHECK`` macro,
+found in ``include/tvm/runtime/logging.h``.
The ``ICHECK`` macro is used in many places in the TVM code to assert
some condition is true during execution; any time the assertion fails, TVM
will exit with the error message shown above.
For more details about how errors are handled and generated by TVM, please
-see `error-handling-guide`.
+see :ref:`error-handling-guide` .
+
+What if I'm using RPC and I'm getting errors?
+---------------------------------------------
+
+First of all, you should enable verbosity and configure logging. If you are
+using android devices, you should also look into adb logcat.
+
+
What should I do when I encounter such an error?
------------------------------------------------
-First of all, *don't panic*. Well, you can panic, but it won't help.
+First of all, *don't panic*. You and most of TVM users are experienced developers,
+so you know how to read source code, how to read stacktraces and how to debug code.
Review Comment:
This sentence could be controversial, maybe replace it with a more "beginner friendly" one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org