[jira] [Comment Edited] (BOOKKEEPER-734) Improve the HashedWheelTimer usage in PerChannelBookieClient

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917802#comment-13917802 ] 

Sijie Guo edited comment on BOOKKEEPER-734 at 3/3/14 7:42 AM:
--------------------------------------------------------------

I would prefer merging BOOKKEEPER-602 into 4.2 rather than making a difference patch in 4.2 branch. if you are OK with that, I would mark fix version as 4.2.3 for BOOKKEEPER-602 and port the change.


was (Author: hustlmsp):
I would prefer merging BOOKKEEPER-602 into 4.2 rather than making a difference patch in 4.2 branch. if you are with that, I would mark fix version as 4.2.3 for BOOKKEEPER-602 and port the change.

> Improve the HashedWheelTimer usage in PerChannelBookieClient
> ------------------------------------------------------------
>
>                 Key: BOOKKEEPER-734
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-734
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.2.2
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.3
>
>         Attachments: 0001-BOOKKEEPER-734_br_4_2.patch
>
>
> Observed two potential cases about the HashedWheelTimer usage:
> # Unnecessary creation of HashedWheelTimer for each channel connection establishment. Instead of creating for each channel connection, we could create one timer per bookie client and close it during permanent closure.
> # Handle IllegalStateException of HashedWheelTimer.releaseExternalResources()



--
This message was sent by Atlassian JIRA
(v6.2#6252)