You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sureshanaparti <gi...@git.apache.org> on 2015/12/16 11:33:14 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1248
CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
Summary: When a new host is added to a cluster, Cloudstack doesn't create all the port groups (created by cloudstack earlier in other hosts) present in the cluster. Since the new host doesn't have all the necessary networking port groups of cloudstack, it is not eligible to participate in DRS load balancing or HA.
Solution: When adding a host to the cluster in Cloudstack, use VMware API to find the list of unique port groups on a previously added host (older host in the cluster) if exists and then create them on the new host.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-9175_VMwareDRSIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1248
----
commit c22ce365936ac08e28527d9192277d8768ecabfa
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-09-21T14:27:03Z
CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.
commit 0d51865f0f7d679d068dd510e00e431ba02c36d8
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-12-15T11:48:31Z
Revert "CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments."
This reverts commit c22ce365936ac08e28527d9192277d8768ecabfa.
commit 2bdb194783284cdf9bdd067f8e757e913151029f
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-12-15T12:13:53Z
Merge branch 'master' of https://github.com/sureshanaparti/cloudstack
commit d3c3f498d19ae623e6b658627087cfc2ec734e67
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-12-16T10:29:14Z
CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
Summary: When a new host is added to a cluster, Cloudstack doesn't create all the port groups (created by cloudstack earlier in other hosts) present in the cluster. Since the new host doesn't have all the necessary networking port groups of cloudstack, it is not eligible to participate in DRS load balancing or HA.
Solution: When adding a host to the cluster in Cloudstack, use VMware API to find the list of unique port groups on a previously added host (older host in the cluster) if exists and then create them on the new host.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1248
This PR is no longer valid since #1257 replaces this. Closing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165088002
`older` is a bit misleading, what about `existent` e.g. findExistentHypervisorHostInCluster?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165547302
@resmo Raised a clean PR: https://github.com/apache/cloudstack/pull/1257.
Shall I close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165410616
@sureshanaparti Ok, I see. then I would indeed use old but suggest `oldest` : `findExistentHypervisorHostInCluster`. Would you mind rebasing to get a clean PR without merge commits and reverts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165412102
@resmo, You mean findOldestExistentHypervisorHostInCluster. I'm OK with it.
Shall I create new PR without all these merges?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-187360919
@sureshanaparti yes, that would be great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165414155
@resmo Sure. I'll do that. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-216208737
@sureshanaparti can you rebase against latest master and share state of your PR, thanks; squash all changes into a single commit
tag:vmware-pickup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165339578
@resmo, Out of all the running hosts present in the cluster, the port groups are fetched from the host which was first added to the cloudstack, assuming that it has all the cloudstack created port groups. So existent may not be the right word. Any other?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165715666
@resmo ok sure. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-181232447
@resmo Shall I close this PR (as #1257 replaces this one)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165712661
since #1257 replaces this PR I would do so, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-165413590
@sureshanaparti that would be great. appreciate your work on vmware parts!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-222320117
### ACS CI BVT Run
**Sumarry:**
Build Number 74
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti closed the pull request at:
https://github.com/apache/cloudstack/pull/1248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---