You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jinxing64 <gi...@git.apache.org> on 2017/02/02 14:21:01 UTC

[GitHub] spark pull request #16779: [SPARK-19437] Rectify spark executor id in Heartb...

GitHub user jinxing64 opened a pull request:

    https://github.com/apache/spark/pull/16779

    [SPARK-19437] Rectify spark executor id in HeartbeatReceiverSuite.

    ## What changes were proposed in this pull request?
    
    The current code in `HeartbeatReceiverSuite`, executorId is set as below:
    ```
      private val executorId1 = "executor-1"
      private val executorId2 = "executor-2"
    ```
    
    The executorId is sent to driver when register as below:
    
    ```
    test("expire dead hosts should kill executors with replacement (SPARK-8119)")  {
      ...
      fakeSchedulerBackend.driverEndpoint.askSync[Boolean](
          RegisterExecutor(executorId1, dummyExecutorEndpointRef1, "1.2.3.4", 0, Map.empty))
      ...
    }
    ```
    
    Receiving `RegisterExecutor` in `CoarseGrainedSchedulerBackend`, the executorId will be compared with `currentExecutorIdCounter` as below:
    ```
    case RegisterExecutor(executorId, executorRef, hostname, cores, logUrls)  =>
      if (executorDataMap.contains(executorId)) {
        executorRef.send(RegisterExecutorFailed("Duplicate executor ID: " + executorId))
        context.reply(true)
      } else {
      ...
      executorDataMap.put(executorId, data)
      if (currentExecutorIdCounter < executorId.toInt) {
        currentExecutorIdCounter = executorId.toInt
      }
      ...
    ```
    
    `executorId.toInt` will cause NumberformatException.
    
    This unit test can pass currently because of `askWithRetry`, when catching exception, RPC will call again, thus it will go `if` branch and return true.
    
    **To fix**
    Rectify executorId and replace `askWithRetry` with `askSync`, refer to https://github.com/apache/spark/pull/16690
    ## How was this patch tested?
    This fix is for unit test and no need to add another one.(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinxing64/spark SPARK-19437

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16779
    
----
commit c8403eafbf11837e315a5e5732d7e2e4ccdc673d
Author: jinxing <ji...@meituan.com>
Date:   2017-02-02T14:14:35Z

    [SPARK-19437] Rectify spark executor id in HeartbeatReceiverSuite.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72297/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    **[Test build #3553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3553/testReport)** for PR 16779 at commit [`06efcac`](https://github.com/apache/spark/commit/06efcacc4db4302ec7a300597d75b2dba1b97d24).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    CC @zsxwing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    **[Test build #72297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72297/testReport)** for PR 16779 at commit [`a9bc3f4`](https://github.com/apache/spark/commit/a9bc3f47b9cd08f309c00c159bc0e1e6a6c6e763).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    Thanks! Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16779: [SPARK-19437] Rectify spark executor id in HeartbeatRece...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16779
  
    **[Test build #3553 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3553/testReport)** for PR 16779 at commit [`06efcac`](https://github.com/apache/spark/commit/06efcacc4db4302ec7a300597d75b2dba1b97d24).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org