[GitHub] andrzej-kaczmarek commented on a change in pull request #218: nimble/ll: Certification fixes part3

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #218: nimble/ll: Certification fixes part3
URL: https://github.com/apache/mynewt-nimble/pull/218#discussion_r226312715
 
 

 ##########
 File path: nimble/controller/include/controller/ble_ll.h
 ##########
 @@ -229,6 +229,15 @@ extern STATS_SECT_DECL(ble_ll_stats) ble_ll_stats;
 #define BLE_LL_FEAT_LE_POWER_CLASS_1 (0x00008000)
 #define BLE_LL_FEAT_MIN_USED_CHAN    (0x00010000)
 
+/* This is initial mask, so if feature exchange will not happen,
+ * but host will want to use this procedure, we will try. If not
+ * succeed, feature bit will be cleared.
+ * Look at LL Features above to find out what is allowed
+ */
+#define BLE_LL_FEAT_INITIAL          (0x00000002)
 
 Review comment:
   I'd call this `BLE_LL_CONN_INITIAL_FEAT(URE)` so it's not confused with single features due to the same prefix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services