You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 23:51:29 UTC

[PR] fix(i18n): localize demo system alerts for english mode [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3171:
URL: https://github.com/apache/rocketmq-dashboard/pull/3171

   ### Summary
   Localize the demo (mock-mode) system alerts so English UI shows English alert copy:
   
   - `SystemAlert` gains optional `enTitle` / `enDescription`; the three bundled demo alerts (`mock/dashboard.ts`) now carry English variants of their titles and descriptions.
   - The System Alerts page picks `enTitle`/`enDescription` when the UI language is English, falling back to the Chinese copy otherwise (Chinese default unchanged, including for related-alert rows).
   
   ### Why
   In demo mode the alerts feed is the first thing operators see; its Chinese titles/descriptions leaked into English UI even after the page chrome was localized.
   
   ### Testing
   - `tsc --noEmit` passes (exit 0).
   - `eslint` clean on changed files (0 errors; one pre-existing exhaustive-deps warning remains).
   - Vitest: `SystemAlertsPage` suite passes (12/12, default-zh assertions unchanged).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize demo system alerts for english mode [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3171: fix(i18n): localize demo system alerts for english mode
URL: https://github.com/apache/rocketmq-dashboard/pull/3171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org