You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2023/11/14 01:10:14 UTC
[PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]
gharris1727 opened a new pull request, #14754:
URL: https://github.com/apache/kafka/pull/14754
These tests leak sockets due to various typos. Additionally, many tests leaked sockets because MiniKdc stops asynchronously, leaving sockets open at the end of the test which are eventually cleaned up. This patch uses the alternative dispose method which awaits termination of the internal resources of the KDC before proceeding with the normal shutdown.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #14754:
URL: https://github.com/apache/kafka/pull/14754#issuecomment-1889959363
It looks like the consistent failures I was seeing were present only on JDK21, didn't reproduce with JDK11, but were already present on trunk. I got some flakey failures with JDK11 locally, but they appear unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 merged PR #14754:
URL: https://github.com/apache/kafka/pull/14754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #14754:
URL: https://github.com/apache/kafka/pull/14754#issuecomment-1847943789
Even through the CI appears to have all of these tests pass, I'm getting some strange failures locally that i'll need to investigate more before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org