[GitHub] [incubator-superset] khtruong commented on a change in pull request #8243: Show Presto views as views, not tables

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #8243: Show Presto views as views, not tables
URL: https://github.com/apache/incubator-superset/pull/8243#discussion_r325788898
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -538,7 +538,9 @@ def get_schema_names(cls, inspector: Inspector) -> List[str]:
         return sorted(inspector.get_schema_names())
 
     @classmethod
-    def get_table_names(cls, inspector: Inspector, schema: Optional[str]) -> List[str]:
+    def get_table_names(
+        cls, database, inspector: Inspector, schema: Optional[str]
 
 Review comment:
   nit: can we add a type for database? comment applies elsewhere

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org