[jira] [Commented] (THRIFT-1412) Thrift Transport classes should manage the lifetime of objects implementing IDisposable by implementing IDisposable themselves.

["Roger Meier (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250090#comment-13250090 ] 

Roger Meier commented on THRIFT-1412:
-------------------------------------

Hi Joshua
patch does not apply, could you create a new one on trunk?
                
> Thrift Transport classes should manage the lifetime of objects implementing IDisposable by implementing IDisposable themselves.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1412
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1412
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>    Affects Versions: 0.7
>            Reporter: Joshua Garvin
>              Labels: patch
>         Attachments: Thrift Transport with IDisposable.patch
>
>
> I have attached a patch to the C# Transport classes to implement IDisposable where needed.  This will ensure that all unmanaged resources such as streams and sockets are properly closed and freed from memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira