You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/10 05:56:17 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4218: Abstract level for literal value
terrymanu opened a new pull request #4218: Abstract level for literal value
URL: https://github.com/apache/incubator-shardingsphere/pull/4218
For #3914.
Changes proposed in this pull request:
- Refactor package structure of value AST node.
- Abstract level for literal value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4218:
Abstract level for literal value
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4218: Abstract level for literal value
URL: https://github.com/apache/incubator-shardingsphere/pull/4218#issuecomment-583973280
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=h1) Report
> Merging [#4218](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/0837bc86968a8da6b447e631abd17c5e821b3b2f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4218 +/- ##
============================================
- Coverage 60.68% 60.67% -0.01%
Complexity 352 352
============================================
Files 1013 1014 +1
Lines 16969 16971 +2
Branches 2992 2992
============================================
Hits 10298 10298
- Misses 6019 6021 +2
Partials 652 652
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxERExWaXNpdG9yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...l/parser/sql/value/collection/CollectionValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvY29sbGVjdGlvbi9Db2xsZWN0aW9uVmFsdWUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...er/sql/value/literal/impl/BooleanLiteralValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvbGl0ZXJhbC9pbXBsL0Jvb2xlYW5MaXRlcmFsVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ser/sql/value/literal/impl/NumberLiteralValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvbGl0ZXJhbC9pbXBsL051bWJlckxpdGVyYWxWYWx1ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...dingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...dingsphere/sql/parser/visitor/MySQLDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQ0xWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...ser/sql/statement/dcl/SetDefaultRoleStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RjbC9TZXREZWZhdWx0Um9sZVN0YXRlbWVudC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=footer). Last update [0837bc8...0850ae0](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4218:
Abstract level for literal value
Posted by GitBox <gi...@apache.org>.
KomachiSion merged pull request #4218: Abstract level for literal value
URL: https://github.com/apache/incubator-shardingsphere/pull/4218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4218:
Abstract level for literal value
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4218: Abstract level for literal value
URL: https://github.com/apache/incubator-shardingsphere/pull/4218#issuecomment-583974181
## Pull Request Test Coverage Report for [Build 9412](https://coveralls.io/builds/28623920)
* **0** of **16** **(0.0%)** changed or added relevant lines in **5** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.006%**) to **64.581%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/literal/impl/BooleanLiteralValue.java](https://coveralls.io/builds/28623920/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fliteral%2Fimpl%2FBooleanLiteralValue.java#L33) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/literal/impl/NumberLiteralValue.java](https://coveralls.io/builds/28623920/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fliteral%2Fimpl%2FNumberLiteralValue.java#L36) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28623920/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L174) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28623920/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L200) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28623920/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L131) | 0 | 8 | 0.0%
<!-- | **Total:** | **0** | **16** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28623920/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28623920) |
| :-- | --: |
| Change from base [Build 806](https://coveralls.io/builds/28622411): | -0.006% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16971 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4218: Abstract level for literal value
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4218: Abstract level for literal value
URL: https://github.com/apache/incubator-shardingsphere/pull/4218#issuecomment-583974181
## Pull Request Test Coverage Report for [Build 1660](https://coveralls.io/builds/28624118)
* **0** of **16** **(0.0%)** changed or added relevant lines in **5** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.587%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/literal/impl/BooleanLiteralValue.java](https://coveralls.io/builds/28624118/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fliteral%2Fimpl%2FBooleanLiteralValue.java#L33) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/literal/impl/NumberLiteralValue.java](https://coveralls.io/builds/28624118/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fliteral%2Fimpl%2FNumberLiteralValue.java#L36) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28624118/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L174) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28624118/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L200) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28624118/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L131) | 0 | 8 | 0.0%
<!-- | **Total:** | **0** | **16** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/28624118) |
| :-- | --: |
| Change from base [Build 806](https://coveralls.io/builds/28622411): | 0.0% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16971 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services