[GitHub] [pinot] richardstartin commented on pull request #8133: Refresh ZK metadata when dimension table is updated

[GitBox <gi...@apache.org>]

richardstartin commented on pull request #8133:
URL: https://github.com/apache/pinot/pull/8133#issuecomment-1030447085


   > Good catch!
   > 
   > We can override `reloadSegment()` method and set the schema to the one passed in. We also need to change `_tableSchema` and `_primaryKeyColumns` to volatile because they can be accessed from a different thread
   
   Actually I think consistency needs to be maintained with the lookup table, so these fields should be updated iff the CAS succeeds. Best way to do this would be to store a volatile wrapper class with all the fields in it, pass the schema and primary key columns into the CAS loop, construct the wrapper then perform the CAS on the wrapper.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org