You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/12/08 01:17:21 UTC

[jira] [Resolved] (HBASE-7303) Quit using reflection for the method DFSOutputStream#getNumCurrentReplicas(…)

     [ https://issues.apache.org/jira/browse/HBASE-7303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J resolved HBASE-7303.
----------------------------

    Resolution: Later

Actually, nevermind. I mistook that we may be dropping 1.x support soon due to reading some text wrongly. Also, 1.x and 2.x have split class differences for the output stream.

We can continue to keep this for now, and remove when we formally drop 1.x support (I wish this comes very soon, HBase has too much code cruft w.r.t. HDFS versions).
                
> Quit using reflection for the method DFSOutputStream#getNumCurrentReplicas(…)
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-7303
>                 URL: https://issues.apache.org/jira/browse/HBASE-7303
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>
> Given that we've raised our minimum version guarantee for HBase with 1.x carrying the 0.20-append code finally, and all subsequent releases (0.21*, 0.22, 0.23 and 2) have this method available in them, I don't see a reason to have the reflection based getNumCurrentReplicas invocation (via HDFS-826) anymore.
> We could save ourselves quite a bit of perf. penalty by removing this check and simply calling the method directly, as its API has not changed across releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira