You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/02/15 06:41:39 UTC

[GitHub] Black-Mamba24 commented on issue #761: [ISSUE #760] Try to fix sendDefualtImpl retry bug and selectOneMessageQueue lastBrokerName bug

Black-Mamba24 commented on issue #761: [ISSUE #760] Try to fix sendDefualtImpl retry bug and selectOneMessageQueue lastBrokerName bug
URL: https://github.com/apache/rocketmq/pull/761#issuecomment-463926598
 
 
   1. I think timeout should devide into timesTotal to retry when timeout once, and timeout still totalTimeout.   long timeoutEveryTime = (long) Math.ceil(timeout / timesTotal);
   2. MQFaultStrategy add "!" if (null == lastBrokerName || !mq.getBrokerName().equals(lastBrokerName))
   3. retryTimesWhenSendFailed, catch exception and continue I think should judge communicationMode, only SYNC can retry

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services